public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: raj.khem@gmail.com, openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] autoconf: Raise line length limit for sed/awk
Date: Fri, 03 Apr 2026 09:53:55 +0100	[thread overview]
Message-ID: <5464d1df292f2c566c753df2f3d43daeda7d0be8.camel@linuxfoundation.org> (raw)
In-Reply-To: <20260403024300.1195438-1-khem.raj@oss.qualcomm.com>

On Thu, 2026-04-02 at 19:43 -0700, Khem Raj via lists.openembedded.org wrote:
> From: Khem Raj <raj.khem@gmail.com>
> 
> Latest autoconf is splitting long cmd lines in config.status
> it generates using sed/awk to have compatibility with
> platform like HPUX,Solaris,AIX which is understandable given
> autotools try to achieve wider portability, however, this does
> mean that in OE builds we might get these newlines added in
> places dividing commands including buildpaths in them and the
> methods deployed to scrub them from output artifacts will fail
> since the string is now on two lines resulting in build QA to
> pass but the strings do sneak in affecting reproducibility
> one such example is e2tools recipe in meta-filesystems and there
> perhaps are more
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  ...-command-limit-to-prevent-line-wrapp.patch | 41 +++++++++++++++++++
>  .../autoconf/autoconf_2.72.bb                 |  1 +
>  2 files changed, 42 insertions(+)
>  create mode 100644 meta/recipes-devtools/autoconf/autoconf/0001-Increase-awk-sed-command-limit-to-prevent-line-wrapp.patch
> 
> diff --git a/meta/recipes-devtools/autoconf/autoconf/0001-Increase-awk-sed-command-limit-to-prevent-line-wrapp.patch b/meta/recipes-devtools/autoconf/autoconf/0001-Increase-awk-sed-command-limit-to-prevent-line-wrapp.patch
> new file mode 100644
> index 0000000000..0713af6d7d
> --- /dev/null
> +++ b/meta/recipes-devtools/autoconf/autoconf/0001-Increase-awk-sed-command-limit-to-prevent-line-wrapp.patch
> @@ -0,0 +1,41 @@
> +From 139f757a6244d3b1e07f7fddc6d07d9c17f45313 Mon Sep 17 00:00:00 2001
> +From: Khem Raj <raj.khem@gmail.com>
> +Date: Tue, 25 Nov 2025 21:03:38 -0800
> +Subject: [PATCH] Increase awk/sed command limit to prevent line wrapping
> +
> +Autoconf 2.70+ wraps long variable assignments in config.status
> +using backslash-newline continuations. This breaks when LDFLAGS
> +or other variables contain special characters.
> +
> +Increase _AC_SED_CMD_LIMIT from 99 and _AC_AWK_LITERAL_LIMIT
> +from 148 to 4000 to prevent wrapping.

The commit message explains why this is needed but the patch needs to
as well (buildpaths being linewrapped and then not being correctly
updated as they're over multiple lines).

Cheers,

Richard


  reply	other threads:[~2026-04-03  8:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-03  2:43 [PATCH] autoconf: Raise line length limit for sed/awk Khem Raj
2026-04-03  8:53 ` Richard Purdie [this message]
2026-04-03 21:31   ` [OE-core] " Khem Raj
  -- strict thread matches above, loose matches on Subject: below --
2025-11-27 16:44 Khem Raj
2025-11-27 17:17 ` [OE-core] " Yoann Congal
2025-12-03  7:23 ` Mathieu Dubois-Briand
2025-12-08 16:24   ` Yoann Congal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5464d1df292f2c566c753df2f3d43daeda7d0be8.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox