From: Liu Jian <jian.liu@windriver.com>
To: Dan McGregor <danismostlikely@gmail.com>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 3/5] logrotate: files will be over written when updating using rpm
Date: Thu, 20 Nov 2014 10:11:13 +0800 [thread overview]
Message-ID: <546D4DC1.7040900@windriver.com> (raw)
In-Reply-To: <CACS+7ZTbE9Tggdpu2g3CyvtpZmyeGw2p5rzha67xZxyMpP2=Jw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1826 bytes --]
于 2014年11月20日 01:54, Dan McGregor 写道:
> On 14 November 2014 03:43, Jian Liu <jian.liu@windriver.com> wrote:
>> If there is no %config micro before the file in the spec file,
>> this file will be over-written after updating this package
>> using rpm.
>> This will make our settings lost.
>>
>> Signed-off-by: Jian Liu <jian.liu@windriver.com>
>> ---
>> meta/recipes-extended/logrotate/logrotate_3.8.7.bb | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/meta/recipes-extended/logrotate/logrotate_3.8.7.bb b/meta/recipes-extended/logrotate/logrotate_3.8.7.bb
>> index faa8e02..8b39602 100644
>> --- a/meta/recipes-extended/logrotate/logrotate_3.8.7.bb
>> +++ b/meta/recipes-extended/logrotate/logrotate_3.8.7.bb
>> @@ -54,3 +54,5 @@ do_install(){
>> install -p -m 755 examples/logrotate.cron ${D}${sysconfdir}/cron.daily/logrotate
>> touch ${D}${localstatedir}/lib/logrotate.status
>> }
>> +
>> +CONFFILES_${PN} += "${localstatedir}/lib/logrotate.status"
> Part of me thinks this shouldn't be an installed file at all; instead
> it should be created by a post install script if it doesn't already
> exist. Thoughts?
It does be contained in rpm package and generated during installation
though it is empty.
It is not created when logrotate is running.
I test it on our WRL6.0 and WRL7.0
So if you update logrotate, logrotate.status will be overwritten during
installation.
All previous status may be lost.
//Liu Jian
>
>> --
>> 1.8.5.2.233.g932f7e4
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
--
Jian Liu
Email: jian.liu@windriver.com
Office Phone: 86-10-84778539
[-- Attachment #2: Type: text/html, Size: 3145 bytes --]
next prev parent reply other threads:[~2014-11-20 2:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 9:43 [PATCH 0/6] Avoid config files being overwritten Jian Liu
2014-11-14 9:43 ` [PATCH 1/5] base-files: files will be over written when updating using rpm Jian Liu
2014-11-20 20:37 ` Burton, Ross
2014-11-21 2:06 ` Liu Jian
2014-11-21 2:23 ` ChenQi
2014-11-20 20:40 ` Burton, Ross
2014-11-14 9:43 ` [PATCH 2/5] initscripts: " Jian Liu
2014-11-14 9:43 ` [PATCH 3/5] logrotate: " Jian Liu
2014-11-19 17:54 ` Dan McGregor
2014-11-20 2:11 ` Liu Jian [this message]
2014-11-20 20:37 ` Burton, Ross
2014-11-14 9:43 ` [PATCH 4/5] libpam: " Jian Liu
2014-11-14 9:43 ` [PATCH 5/5] nfs-utils: " Jian Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546D4DC1.7040900@windriver.com \
--to=jian.liu@windriver.com \
--cc=danismostlikely@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox