Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: "Aníbal Limón" <anibal.limon@linux.intel.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 00/12] Usage bitbake fetcher latest_versionstring in distrodata_class
Date: Tue, 02 Dec 2014 14:52:43 -0800	[thread overview]
Message-ID: <547E42BB.6010604@linux.intel.com> (raw)
In-Reply-To: <cover.1417134564.git.anibal.limon@linux.intel.com>

On 11/27/2014 05:09 PM, Aníbal Limón wrote:
> Since Bitbake fetcher has latest_versionstring method that support search last version
> of package in upstream sites, distrodata class should use it instead of do itself,
>
> Summary of changes,
>
> distrodata_class: Re-implement upstream version detection using Bitbake fetcher methods.
> package_regex.inc: Update regex because Bitbake fetcher already provides support for search
> in HTML href's tags instead of RAW lines.
> bitbake: Improvements in fetcher wget latest_versionstring method based on [1] and clean code.
>
> Compatibility testing was made running distrodata class and the result files can be found at [1].
>
> The code has DEPENDENCIES the Bitbake changes should be MERGE first then package_regex.inc
> and finally distrodata_class.
>
> [1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=1813
>
> The following changes since commit 0bc03af7ee6112fa0af0608b02f715ec8495e4ff:
>
>    maintainers.inc: update maintainers (2014-11-26 17:06:10 +0000)
>
> are available in the git repository at:
>
>    git://git.yoctoproject.org/poky-contrib alimon/fetcher-distrodata
>    http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=alimon/fetcher-distrodata
>
> Aníbal Limón (12):
>    distrodata_class: checkpkg make usage of latest_versionstring methods
>      in bitbake fetcher
>    package_regex.inc: Update REGEX'es in order to find upstream versions
>      correctly
>    fetch2/wget.py: latest_versionstring create _init_regex method for
>      have one place when regex'es are defined
>    fetch2/wget.py: _init_regexes rename variables to be more consistent
>      and move dirver_regex into it
>    fetch/wget.php: latest version string only try to find latest
>      directory when REGEX_URI isn't specified to avoid unnecessary
>      processing and makes code easier
>    fetch2/wget.py: latest_versionstring add package_custom_regex_comp
>    fetch2/wget.py: latest_versionstring improvments in searching
>    fetch/wget.py: latest_versionstring remove unnecessary usage for name
>      in version comparision
>    fetch2/wget: latest_versionstring add support for search in RAW html
>      lines
>    fetch/wget.py: latest_versionstring remove newuri set because is
>      previous set
>    tests/fetch.py: Update wget latest_versionstring cups case
>    fetch2/wget.py: latest_versionstring clean improvments minor
>
>   bitbake/lib/bb/fetch2/wget.py                    | 146 ++++---
>   bitbake/lib/bb/tests/fetch.py                    |   2 +-
>   meta-yocto/conf/distro/include/package_regex.inc | 400 +++++++++---------
>   meta/classes/distrodata.bbclass                  | 492 ++---------------------
>   4 files changed, 337 insertions(+), 703 deletions(-)
>
I know you are using the create-pull-request script, but you should to 
it once per repo that you are doing it with, for example here in bitbake 
repo and a second one in the oe-core repo, so that does not people 
looking for the other 11 patches in oe-core vs bitbake.

Sau!



      parent reply	other threads:[~2014-12-02 22:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-28  1:09 [PATCH 00/12] Usage bitbake fetcher latest_versionstring in distrodata_class Aníbal Limón
2014-11-28  1:09 ` [PATCH 01/12] distrodata_class: checkpkg make usage of latest_versionstring methods in bitbake fetcher Aníbal Limón
2014-12-02 22:52 ` Saul Wold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=547E42BB.6010604@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=anibal.limon@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox