From: Bruce Ashfield <bruce.ashfield@windriver.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>,
openembedded-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] kernelsrc.bbclass: Ensure fetch/unpack/patch tasks don't run
Date: Fri, 19 Dec 2014 09:15:22 -0500 [thread overview]
Message-ID: <549432FA.5000005@windriver.com> (raw)
In-Reply-To: <1418995131.13316.18.camel@linuxfoundation.org>
On 14-12-19 08:18 AM, Richard Purdie wrote:
> In particular this removes a race condition where a ${S}/patches
> directory could be created by do_unpack. This confuses kern-tools.
Looks good here. This will keep the dreaded 'patches' directory from
popping up and mucking up the existing detection of meta data.
On a related note, I'll see about making things more robust on the
detection end as well.
Cheers,
Bruce
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>
> diff --git a/meta/classes/kernelsrc.bbclass b/meta/classes/kernelsrc.bbclass
> index 11f04e9..4208eff 100644
> --- a/meta/classes/kernelsrc.bbclass
> +++ b/meta/classes/kernelsrc.bbclass
> @@ -1,5 +1,8 @@
> S = "${STAGING_KERNEL_DIR}"
> +do_fetch[noexec] = "1"
> do_unpack[depends] += "virtual/kernel:do_patch"
> +do_unpack[noexec] = "1"
> +do_patch[noexec] = "1"
> do_package[depends] += "virtual/kernel:do_populate_sysroot"
> KERNEL_VERSION = "${@get_kernelversion_file("${S}")}"
>
>
>
prev parent reply other threads:[~2014-12-19 14:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-19 13:18 [PATCH] kernelsrc.bbclass: Ensure fetch/unpack/patch tasks don't run Richard Purdie
2014-12-19 14:15 ` Bruce Ashfield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=549432FA.5000005@windriver.com \
--to=bruce.ashfield@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox