Re: [PATCH 3/3] libsm: remove dependency on e2fsprogs

[ChenQi <Qi.Chen@windriver.com>]

On 01/04/2015 05:09 PM, Mike Looijmans wrote:
> On 01/04/2015 03:11 AM, Chen Qi wrote:
>> This patch is to solve the following circular dependency problem.
>>
>>       systemd -> dbus -> libsm -> e2fsprogs -> util-linux -> systemd
>>
>> libsm doesn't have any dependency on e2fsprogs. It might be some 
>> dependency
>> on util-linux's libuuid, controlled by configure options. So 
>> e2fsprogs should
>> be removed from the DEPENDS variable.
>>
>> Ideally, we should add a PACKAGECONFIG for 'libuuid' for libsm. 
>> However, if
>> libsm depends on util-linux, we would have the circular dependency 
>> described
>> above. That's why this patch explicitly set '--without-libuuid' in 
>> EXTRA_OECONF.
>> libsm would still be working well because it would fall back to an 
>> internal
>> algorithm to do the uuid stuff.
>
> Maybe libuuid should get its own recipe. It can be built from the 
> util-linux sources. Other packages can then just depend on that 
> libuuid recipe instead of util-linux itself.
>
> Only problem would be util-linux I guess, you'd get two providers for 
> libuuid.
>

I thought about this approach too. I didn't use it because of the 
following reasons.

1) IMHO, we haven't reached a point that a separate libuuid recipe 
becomes a necessity.
     Splitting a recipe may need more compelling reasons.
2) If we are really going to do so, I think we may need an RFC in other 
patches. I don't want to make a patchset regarding package upgrades 
involve too many changes.

Best Regards,
Chen Qi