Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Mike Looijmans <mike.looijmans@topic.nl>
To: Bruce Ashfield <bruce.ashfield@gmail.com>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: What is expected of a kernel recipe nowadays?
Date: Tue, 6 Jan 2015 08:14:33 +0100	[thread overview]
Message-ID: <54AB8B59.7080702@topic.nl> (raw)
In-Reply-To: <CADkTA4MgqEASmHgGunCkTUR=1qdgxP6dqW90PmgYmZ2HHTUWPg@mail.gmail.com>

On 01/05/2015 09:18 PM, Bruce Ashfield wrote:
> On Mon, Jan 5, 2015 at 3:29 AM, Mike Looijmans <mike.looijmans@topic.nl> wrote:
>> I think I found it. The kernel bbclass changes "S" to point elsewhere.
>> Moving the statement
>> S = "${WORKDIR}/git"
>> to after the "inherit kernel" line makes the compile run again.
>
>
> Interesting. Can you confirm that Richard's commit:
>
> -----------------
>
> commit 1dd37a2a9960ad26e27567d1871d78bec336e1a2
> Author: Richard Purdie <richard.purdie@linuxfoundation.org>
> Date:   Fri Dec 19 17:46:27 2014 +0000
>
>      kernel: Fix non linux-yocto builds
>
>      After the recent kernel changes, non linux-yocto builds stopped working
>      properly for two reasons:
>
>      a) ${S} was being reset to ${WORKDIR}/git for example and STAGING_KERNEL_DIR
>         did not contain the source
>
>      b) Most builds were using ${B} == ${S}
>
>      This patch adds a fixup to the unpack function to handle the case where
>      ${S} != ${STAGING_KERNEL_DIR} and also set up the infrastrcture so that
>      B != S for kernel builds from now on. The kernel build system is one of the
>      best for supporting this and there is no good reason not to take advantage
>      of it.
>
>      (From OE-Core rev: 106dab2fd0321e6b4e77b40111e59a3a31d329d4)
>
>      Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>
> ------------
>
> Is in your tree ? it should be fixing things up and allowing the source to
> be found.

Yes, this is the part that changes "S" and it's how I discovered to move the 
assignment to after inheriting it.


> Alternatively, if you drop the explicit set of S, does the build start working
> again ?

If I just remove the S=... line, it fails in the same way. The git fetch 
apparently places the code at WORKDIR/git where the new kernel recipe cannot 
find it.




Met vriendelijke groet / kind regards,

Mike Looijmans
System Expert


TOPIC Embedded Systems
Eindhovenseweg 32-C, NL-5683 KH Best
Postbus 440, NL-5680 AK Best
Telefoon: (+31) (0) 499 33 69 79
Telefax:  (+31) (0) 499 33 69 70
E-mail: mike.looijmans@topic.nl
Website: www.topic.nl

Please consider the environment before printing this e-mail

Topic zoekt gedreven (embedded) software specialisten!
http://topic.nl/vacatures/topic-zoekt-software-engineers/



  parent reply	other threads:[~2015-01-06  7:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-05  8:03 What is expected of a kernel recipe nowadays? Mike Looijmans
2015-01-05  8:29 ` Mike Looijmans
2015-01-05 20:18   ` Bruce Ashfield
2015-01-06  0:47     ` Otavio Salvador
2015-01-06  7:14     ` Mike Looijmans [this message]
2015-01-06  8:57       ` Martin Jansa
2015-01-06 11:04         ` Martin Jansa
2015-01-06 11:33           ` Burton, Ross
2015-01-06 14:08             ` Bruce Ashfield
2015-01-06 11:08         ` Burton, Ross
2015-01-07 10:07           ` Martin Jansa
2015-01-07 13:08             ` Bruce Ashfield
2015-01-07 15:48             ` Bruce Ashfield
2015-01-07 15:56               ` Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54AB8B59.7080702@topic.nl \
    --to=mike.looijmans@topic.nl \
    --cc=bruce.ashfield@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox