From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mail.openembedded.org (Postfix) with ESMTP id 4F2A365C85 for ; Tue, 13 Jan 2015 22:50:03 +0000 (UTC) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 13 Jan 2015 14:46:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,752,1413270000"; d="scan'208,217";a="636868910" Received: from aehernan-devstation.zpn.intel.com (HELO [10.219.4.144]) ([10.219.4.144]) by orsmga001.jf.intel.com with ESMTP; 13 Jan 2015 14:49:22 -0800 Message-ID: <54B5A103.4000201@linux.intel.com> Date: Tue, 13 Jan 2015 16:49:39 -0600 From: Alejandro Hernandez User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: "Burton, Ross" References: <4bedbe90e0589179b7c6010818a63596a9502671.1418337489.git.alejandro.hernandez@linux.intel.com> In-Reply-To: Cc: OE-core Subject: Re: [PATCH 1/1] insane.bbclass: Added QA test for expanded ${D} X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Jan 2015 22:50:12 -0000 Content-Type: multipart/alternative; boundary="------------060902020805050501000701" --------------060902020805050501000701 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Thank Ross, sending new patch soon. On 07/01/15 12:27, Burton, Ross wrote: > Hi Alejandro, > > Looks good, but some small points: > > On 11 December 2014 at 22:40, Alejandro Hernandez > > wrote: > > - version-going-backwards \ > + version-going-backwards expanded_d \ > > +QAPATHTEST[expanded_d] = "package_qa_check_expanded_d" > > > Rename this to expanded-d for consistency with the other symbols that > use - instead of _. > > + # Variables are actually var_${PN} > > > No need to document idioms, remove this comment. > > + messages["expanded_d"] = "FILES should not > contain the ${D} variable as it references the local build > directory not the target filesystem, best solution is to remove > the ${D} reference" > > > This doesn't name the package which makes it tricky to find in large > builds. > > Ross > --------------060902020805050501000701 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit Thank Ross, sending new patch soon.
On 07/01/15 12:27, Burton, Ross wrote:
Hi Alejandro,

Looks good, but some small points:

On 11 December 2014 at 22:40, Alejandro Hernandez <alejandro.hernandez@linux.intel.com> wrote:
-            version-going-backwards \
+            version-going-backwards expanded_d \
+QAPATHTEST[expanded_d] = "package_qa_check_expanded_d"

Rename this to expanded-d for consistency with the other symbols that use - instead of _.
  
+            # Variables are actually var_${PN}

No need to document idioms, remove this comment.
 
+                        messages["expanded_d"] = "FILES should not contain the ${D} variable as it references the local build directory not the target filesystem, best solution is to remove the ${D} reference"

This doesn't name the package which makes it tricky to find in large builds.

Ross 


--------------060902020805050501000701--