[PATCH] perl: Backport fix for bug #123591

[PATCH] perl: Backport fix for bug #123591

[Gary Thomas]

This patch fixes a crash in perl when using formatted strings @...

Signed-off-by: Gary Thomas <gary@mlbassoc.com>
---
 .../perl/perl-5.20.0/fix-FF_MORE-crash.patch        | 21 +++++++++++++++++++++
 meta/recipes-devtools/perl/perl_5.20.0.bb           |  1 +
 2 files changed, 22 insertions(+)
 create mode 100644 meta/recipes-devtools/perl/perl-5.20.0/fix-FF_MORE-crash.patch

diff --git a/meta/recipes-devtools/perl/perl-5.20.0/fix-FF_MORE-crash.patch b/meta/recipes-devtools/perl/perl-5.20.0/fix-FF_MORE-crash.patch
new file mode 100644
index 0000000..85cfa05
--- /dev/null
+++ b/meta/recipes-devtools/perl/perl-5.20.0/fix-FF_MORE-crash.patch
@@ -0,0 +1,21 @@
+Upstream-Status: Backport
+Reference: https://rt.perl.org/Public/Bug/Display.html?id=123591
+  From 62db6ea5fed19611596cbc5fc0b8a4df2c604e58 Mon Sep 17 00:00:00 2001
+  From: Tony Cook <tony@develop-help.com>
+  Date: Mon, 19 Jan 2015 16:03:18 +1100
+  Subject: [PATCH 1/1] [perl #123538] always set chophere and itembytes at the same time
+
+  Previously this would crash in FF_MORE because chophere was still NULL.
+
+Index: perl-5.20.0/pp_ctl.c
+===================================================================
+--- perl-5.20.0.orig/pp_ctl.c
++++ perl-5.20.0/pp_ctl.c
+@@ -590,6 +590,7 @@ PP(pp_formline)
+                         break;
+                 }
+                 itembytes = s - item;
++                chophere = s;
+ 		break;
+ 	    }
+ 
diff --git a/meta/recipes-devtools/perl/perl_5.20.0.bb b/meta/recipes-devtools/perl/perl_5.20.0.bb
index 3ca0f53..bc7866b 100644
--- a/meta/recipes-devtools/perl/perl_5.20.0.bb
+++ b/meta/recipes-devtools/perl/perl_5.20.0.bb
@@ -63,6 +63,7 @@ SRC_URI += " \
 	file://fix_bad_rpath.patch \
 	file://perl-archlib-exp.patch \
 	file://dynaloaderhack.patch \
+	file://fix-FF_MORE-crash.patch \
 	\
         \
         file://config.sh \
-- 
1.9.1

Re: [PATCH] perl: Backport fix for bug #123591

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 236 bytes --]

On 19 January 2015 at 14:20, Gary Thomas <gary@mlbassoc.com> wrote:

> @@ -0,0 +1,21 @@
> +Upstream-Status: Backport
> +Reference: https://rt.perl.org/Public/Bug/Display.html?id=123591
>

This needs to be Signed-off-by.

Ross

[-- Attachment #2: Type: text/html, Size: 724 bytes --]

Re: [PATCH] perl: Backport fix for bug #123591

[Gary Thomas]

On 2015-01-20 08:49, Burton, Ross wrote:
>
> On 19 January 2015 at 14:20, Gary Thomas <gary@mlbassoc.com <mailto:gary@mlbassoc.com>> wrote:
>
>     @@ -0,0 +1,21 @@
>     +Upstream-Status: Backport
>     +Reference: https://rt.perl.org/Public/Bug/Display.html?id=123591
>
>
> This needs to be Signed-off-by.

By whom?  There is no Signed-off-by in the perl commit.

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

Re: [PATCH] perl: Backport fix for bug #123591

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 281 bytes --]

On 20 January 2015 at 16:13, Gary Thomas <gary@mlbassoc.com> wrote:

> This needs to be Signed-off-by.
>>
>
> By whom?  There is no Signed-off-by in the perl commit.


By you, along with the Upstream-Status.  We like to know in five years time
who added a patch.

Ross

[-- Attachment #2: Type: text/html, Size: 748 bytes --]