Re: [PATCH] image: Add missing depends on virtual/kernel for depmod data

[Bruce Ashfield <bruce.ashfield@windriver.com>]

On 15-01-27 10:29 AM, Richard Purdie wrote:
> We need the depmod data so that the kernel depmod command works successfully
> at rootfs time. The fact this was working inconsistently is now highlighted
> after the command was made to error out. A simple test case is:
>
> bitbake virtual/kernel image
> bitbake vrituak/kernel -c clean
> bitbake image -c rootfs -f
>
> We fix it by adding the missing dependency.

Looks good here.

Out of curiosity, was this hiding before, or did it only come about due
to our recent moves to the work-shared kernel builds ?

Bruce


>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index 22b6970..5b88f53 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -72,8 +72,10 @@ LDCONFIGDEPEND ?= "ldconfig-native:do_populate_sysroot"
>   LDCONFIGDEPEND_libc-uclibc = ""
>   LDCONFIGDEPEND_libc-musl = ""
>
> -do_rootfs[depends] += "makedevs-native:do_populate_sysroot virtual/fakeroot-native:do_populate_sysroot ${LDCONFIGDEPEND}"
> -do_rootfs[depends] += "virtual/update-alternatives-native:do_populate_sysroot update-rc.d-native:do_populate_sysroot"
> +do_rootfs[depends] += " \
> +    makedevs-native:do_populate_sysroot virtual/fakeroot-native:do_populate_sysroot ${LDCONFIGDEPEND} \
> +    virtual/update-alternatives-native:do_populate_sysroot update-rc.d-native:do_populate_sysroot \
> +    virtual/kernel:do_populate_sysroot"
>   do_rootfs[recrdeptask] += "do_packagedata"
>
>   def command_variables(d):
>
>