From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail1.windriver.com (mail1.windriver.com [147.11.146.13]) by mail.openembedded.org (Postfix) with ESMTP id 55FBC72374 for ; Thu, 12 Feb 2015 09:26:47 +0000 (UTC) Received: from ALA-HCB.corp.ad.wrs.com (ala-hcb.corp.ad.wrs.com [147.11.189.41]) by mail1.windriver.com (8.14.9/8.14.5) with ESMTP id t1C9Qij3007736 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Thu, 12 Feb 2015 01:26:44 -0800 (PST) Received: from [128.224.162.174] (128.224.162.174) by ALA-HCB.corp.ad.wrs.com (147.11.189.41) with Microsoft SMTP Server id 14.3.174.1; Thu, 12 Feb 2015 01:26:43 -0800 Message-ID: <54DC71D2.3020607@windriver.com> Date: Thu, 12 Feb 2015 17:26:42 +0800 From: Robert Yang User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Henning Heinold , References: <20150212091423.GA18807@mail.itconsulting-heinold.de> In-Reply-To: <20150212091423.GA18807@mail.itconsulting-heinold.de> Subject: Re: [PATCH 2/7] libtool: don't execute automake and autoconf on every invocation X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Feb 2015 09:26:52 -0000 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 8bit On 02/12/2015 05:14 PM, Henning Heinold wrote: > On Thu, Feb 12, 2015 at 01:07:35AM -0800, Robert Yang wrote: >> From the origin commit message: >> Regression from 2.4.2 was causing noticable slow-down in builds >> that call libtool many times. >> * build-aux/ltmain.in (func_help): Override func_help() from >> gl/build-aux/options-parser to only run automake --version and >> autoconf --version when libtool --help is executed on the command >> line. >> >> Signed-off-by: Robert Yang >> --- >> meta/recipes-devtools/libtool/libtool-2.4.5.inc | 1 + >> ...-t-execute-automake-and-autoconf-on-every.patch | 71 ++++++++++++++++++++ >> 2 files changed, 72 insertions(+) >> create mode 100644 meta/recipes-devtools/libtool/libtool/libtool-don-t-execute-automake-and-autoconf-on-every.patch >> >> diff --git a/meta/recipes-devtools/libtool/libtool-2.4.5.inc b/meta/recipes-devtools/libtool/libtool-2.4.5.inc >> index 88e281f..0f6bdc8 100644 >> --- a/meta/recipes-devtools/libtool/libtool-2.4.5.inc >> +++ b/meta/recipes-devtools/libtool/libtool-2.4.5.inc >> @@ -19,6 +19,7 @@ SRC_URI = "${GNU_MIRROR}/libtool/libtool-${PV}.tar.gz \ >> file://fix-resolve-lt-sysroot.patch \ >> file://nohardcodepaths.patch \ >> file://unwind-opt-parsing.patch \ >> + file://libtool-don-t-execute-automake-and-autoconf-on-every.patch \ >> " >> >> SRC_URI[md5sum] = "7d30ed9fa6bb11270ebb31639a37bd54" >> diff --git a/meta/recipes-devtools/libtool/libtool/libtool-don-t-execute-automake-and-autoconf-on-every.patch b/meta/recipes-devtools/libtool/libtool/libtool-don-t-execute-automake-and-autoconf-on-every.patch >> new file mode 100644 >> index 0000000..f48f09c >> --- /dev/null >> +++ b/meta/recipes-devtools/libtool/libtool/libtool-don-t-execute-automake-and-autoconf-on-every.patch >> @@ -0,0 +1,71 @@ >> +From 408cfb9c5fa8a666917167ffb806cb19deded429 Mon Sep 17 00:00:00 2001 >> +From: "Gary V. Vaughan" >> +Date: Fri, 6 Feb 2015 12:58:34 +0000 >> +Subject: [PATCH] libtool: don't execute automake and autoconf on every >> + invocation. >> + >> +Regression from 2.4.2 was causing noticable slow-down in builds >> +that call libtool many times. >> +* build-aux/ltmain.in (func_help): Override func_help() from >> +gl/build-aux/options-parser to only run automake --version and >> +autoconf --version when libtool --help is executed on the command >> +line. >> +* NO-THANKS: Add Robert Yang. >> +Reported by Robert Yang >> + >> +Signed-off-by: Gary V. Vaughan >> + > > typo >> +Updated: Change NO-THANKS to THANKS to apply the patch since upsream > ^^^^^^^ Thanks, fixed in the repo. // Robert >> +renamed it. >> + >> +Upstream-Stauts: Backport >> + >> +Signed-off-by: Robert Yang >> + >> +--- >> + THANKS | 1 + >> + build-aux/ltmain.in | 9 ++++++++- >> + 2 files changed, 9 insertions(+), 1 deletion(-) >> + >> +diff --git a/THANKS b/THANKS >> +index 0ab162d..aa7aa8c 100644 >> +--- a/THANKS >> ++++ b/THANKS >> +@@ -258,6 +258,7 @@ Robert Garron Robert.Garron@Access3000.net >> + Robert Millan rmh@aybabtu.com >> + Robert Ögren lists@roboros.com >> + Roberto Bagnara bagnara@cs.unipr.it >> ++Robert Yang liezhi.yang@windriver.com >> + Roger Cornelius rac@tenzing.org >> + Roland Mainz roland.mainz@nrubsig.org >> + Roumen Petrov bugtrack@roumenpetrov.info >> +diff --git a/build-aux/ltmain.in b/build-aux/ltmain.in >> +index 46a0bb5..d5cf07a 100644 >> +--- a/build-aux/ltmain.in >> ++++ b/build-aux/ltmain.in >> +@@ -127,7 +127,12 @@ usage_message="Options: >> + " >> + >> + # Additional text appended to 'usage_message' in response to '--help'. >> +-long_help_message=$long_help_message" >> ++func_help () >> ++{ >> ++ $debug_cmd >> ++ >> ++ func_usage_message >> ++ $ECHO "$long_help_message >> + >> + MODE must be one of the following: >> + >> +@@ -158,6 +163,8 @@ include the following information: >> + Report bugs to <@PACKAGE_BUGREPORT@>. >> + GNU @PACKAGE@ home page: <@PACKAGE_URL@>. >> + General help using GNU software: ." >> ++ exit 0 >> ++} >> + >> + >> + # func_lo2o OBJECT-NAME > > Bye Henning >