From: Robert Yang <liezhi.yang@windriver.com>
To: Paul Eggleton <paul.eggleton@linux.intel.com>,
Chong Lu <Chong.Lu@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH V5 0/2] bitbake-layers: add a ability to query layer dependencies from layer index
Date: Fri, 13 Feb 2015 22:01:20 +0800 [thread overview]
Message-ID: <54DE03B0.7070308@windriver.com> (raw)
In-Reply-To: <11486297.dKnYkC7eTZ@peggleto-mobl5.ger.corp.intel.com>
On 02/13/2015 06:10 PM, Paul Eggleton wrote:
> On Thursday 12 February 2015 09:50:21 Chong Lu wrote:
>> Change since V4:
>> Change commit log for two variables.
>>
>> The following changes since commit 35c9fa0588ed8e88b541a6c80cc1517324616cea:
>>
>> maintainers: Update for non-maintained recipes (2015-01-20 21:39:41 +0000)
>>
>> are available in the git repository at:
>>
>> git://git.pokylinux.org/poky-contrib chonglu/layerindex
>> http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=chonglu/layerindex
>>
>> Chong Lu (2):
>> bitbake.conf: Add two variables for layer index
>> bitbake-layers: add a ability to query layer dependencies from layer index
>
> Thanks for fixing nearly all of the issues from v3 - I've tested it and it
> works pretty well. However, there is one that is still not addressed:
>
>>> * I think the new subcommand would make more sense if it were switched
>>> around so that it was fetching by default (and renamed as appropriate).
>>> Perhaps "layerindex-fetch" (with -n to avoid fetching and just report what
>>> it would fetch).
>
> FWIW I'm happy if we still have a "layerindex-show-deps" that is just an alias
> for "layerindex-fetch -n", so it's really about the naming.
>
> Additionally I'd really rather we did not hardcode the branch names - there's
> an API call available to get these in the layer index and we should use it. I
> also think we could improve the formatting of the output to make it a bit
> easier for the user to understand.
>
> I know you'll be out of office for the next few weeks - perhaps I could address
> these issues while you're out and send a new series if you have no objections.
Thank you very much, I had talked with Chong today, he would be very happy
if you can send the new series:-)
// Robert
>
> Cheers,
> Paul
>
prev parent reply other threads:[~2015-02-13 14:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 1:50 [PATCH V5 0/2] bitbake-layers: add a ability to query layer dependencies from layer index Chong Lu
2015-02-12 1:50 ` [PATCH V5 1/2] bitbake.conf: Add two variables for " Chong Lu
2015-02-12 1:50 ` [PATCH V5 2/2] bitbake-layers: add a ability to query layer dependencies from " Chong Lu
2015-02-13 10:10 ` [PATCH V5 0/2] " Paul Eggleton
2015-02-13 14:01 ` Robert Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DE03B0.7070308@windriver.com \
--to=liezhi.yang@windriver.com \
--cc=Chong.Lu@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=paul.eggleton@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox