From: Ross Burton <Ross.Burton@arm.com>
To: "pratik.farkase@est.tech" <pratik.farkase@est.tech>
Cc: "openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>,
"pratik.farkase@ericsson.com" <pratik.farkase@ericsson.com>
Subject: Re: [OE-core][PATCH v3] libyaml: add ptest support
Date: Mon, 1 Dec 2025 17:39:39 +0000 [thread overview]
Message-ID: <54E0E367-D771-43F9-98AC-DEF6F1FE66CB@arm.com> (raw)
In-Reply-To: <20251121131306.19079-1-pratik.farkase@est.tech>
On 21 Nov 2025, at 13:13, Pratik Farkase via lists.openembedded.org <pratik.farkase=est.tech@lists.openembedded.org> wrote:
> + if [ -f ${B}/tests/.libs/${test} ]; then
Don’t make this conditional, as otherwise the test list won’t be updated.
> + install -m 0755 ${B}/tests/.libs/${test} ${D}${PTEST_PATH}/tests/
Use ${B}/libtool —mode=install install ${B}/tests/$test ${D}${PTEST_PATH}/tests/ please. Assuming that libtool writes into .libs/ is a bad assumption.
Ross
next prev parent reply other threads:[~2025-12-01 17:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 10:56 [OE-core][PATCH] libyaml: add ptest support Pratik Farkase
2025-11-21 11:22 ` Yoann Congal
2025-11-21 11:57 ` Pratik Farkase
2025-11-21 11:54 ` [OE-core][PATCH v2] " Pratik Farkase
2025-11-21 12:32 ` Yoann Congal
2025-11-21 13:17 ` Pratik Farkase
2025-11-21 13:13 ` [OE-core][PATCH v3] " Pratik Farkase
2025-11-21 14:46 ` Yoann Congal
2025-12-01 17:39 ` Ross Burton [this message]
2025-12-04 13:24 ` Ross Burton
2026-01-08 9:17 ` [OE-core][PATCH v4] " Pratik Farkase
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E0E367-D771-43F9-98AC-DEF6F1FE66CB@arm.com \
--to=ross.burton@arm.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=pratik.farkase@ericsson.com \
--cc=pratik.farkase@est.tech \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox