From: Mark Hatle <mark.hatle@windriver.com>
To: Christopher Larson <clarson@kergoth.com>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] package_rpm.bbclass: support packaging of symlinks to directories
Date: Tue, 17 Feb 2015 11:09:06 -0600 [thread overview]
Message-ID: <54E375B2.9080002@windriver.com> (raw)
In-Reply-To: <CABcZAN=4puvBHBwH72ioVdGHpfSO5kngJGCWrJgED8xO_4xQkw@mail.gmail.com>
On 2/17/15 10:57 AM, Christopher Larson wrote:
>
> On Tue, Feb 17, 2015 at 9:54 AM, Mark Hatle <mark.hatle@windriver.com
> <mailto:mark.hatle@windriver.com>> wrote:
>
> On 2/17/15 7:42 AM, Patrick Ohly wrote:
> > os.walk() returns symlinks to directories in the "dirs" lists,
> > but then never enters them by default. As a result, the old
> > code applied neither the directory handling (because that
> > is active once a directory gets entered) nor the file handling,
> > and thus never packaged such symlinks.
> >
> > The fix is simple: find such special directory entries and move
> > them to the "files" list.
>
> I'm curious, what is the problem that is being fixed with this.
>
> Normally you don't want to walk into symlinks to directories, as either you want
> to capture the symlink itself -- or the symlink is pointing to something you
> don't have access to when packaging (i.e. /proc).
>
>
> This patch doesn't make it walk into the directory symlinks, it moves them into
> the files list rather than the dirs list so they'll be captured themselves, as
> far as I can tell from reading it.
Ok.. I missed that bit.. I'm still curious what this fixes.
--Mark
next prev parent reply other threads:[~2015-02-17 17:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-17 13:42 [PATCH] package_rpm.bbclass: support packaging of symlinks to directories Patrick Ohly
2015-02-17 15:55 ` Christopher Larson
2015-02-18 8:43 ` Patrick Ohly
2015-02-18 9:08 ` Patrick Ohly
2015-02-17 16:54 ` Mark Hatle
2015-02-17 16:57 ` Christopher Larson
2015-02-17 17:09 ` Mark Hatle [this message]
2015-02-18 3:40 ` Dan McGregor
2015-02-18 8:45 ` Patrick Ohly
2015-02-18 14:54 ` Mark Hatle
2015-02-25 14:51 ` [PATCH v2] " Patrick Ohly
2015-02-25 15:18 ` Patrick Ohly
2015-02-25 14:53 ` [PATCH v3] " Patrick Ohly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E375B2.9080002@windriver.com \
--to=mark.hatle@windriver.com \
--cc=clarson@kergoth.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox