Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Sven Ebenfeld <sven.ebenfeld@gmail.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] terminal.py: No --disable-factory for gnome-terminal >= 3.10
Date: Mon, 23 Feb 2015 20:41:58 +0100	[thread overview]
Message-ID: <54EB8286.10101@gmail.com> (raw)
In-Reply-To: <CAJTo0LYY0Gh2p6p-vofrXxYQnfjKRwazoz+khs7HpyG==3Zvsg@mail.gmail.com>

Hi Ross,

Thank you for your replies!
I've reworked my patch and submitted it again.

Cheers,
Sven

Am 23.02.2015 um 14:34 schrieb Burton, Ross:
> Hi again,
> 
> On 21 February 2015 at 10:44, Sven Ebenfeld <sven.ebenfeld@gmail.com> wrote:
> 
>> +        vernum = check_konsole_version("gnome-terminal")
>> +        if vernum:
>> +            major = int(vernum.split('.')[0])
>> +            minor = int(vernum.split('.')[1])
>>
> 
> And whilst you're editing this code, doing the split inside
> check_terminal_version and returning a tuple would clean it up nicely:
> 
> def get_terminal_version():
>     ...
>     return ver.split()[-1].split('.')[:2]
> (major, minor) = get_terminal_version()
> 
> Ross
> 


      reply	other threads:[~2015-02-23 19:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-21 10:44 [PATCH] terminal.py: No --disable-factory for gnome-terminal >= 3.10 Sven Ebenfeld
2015-02-23 13:30 ` Burton, Ross
2015-02-23 13:34 ` Burton, Ross
2015-02-23 19:41   ` Sven Ebenfeld [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54EB8286.10101@gmail.com \
    --to=sven.ebenfeld@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox