Re: [PATCH 1/3] dbus: split tools package.

[Andreas Oberritter <obi@opendreambox.org>]

Hello Gustavo,

On 04.03.2015 22:27, Bruno Bottazzini wrote:
> From: Gustavo Sverzut Barbieri <gustavo.barbieri@intel.com>
> 
> Most tools are not required if one is launching a simple daemon.
> The user will be able to exclude dbus-tool and save some space in his
> build
> 
> Signed-off-by: Bruno Bottazzini <bruno.bottazzini@intel.com>
> ---
>  meta/recipes-core/dbus/dbus.inc | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-core/dbus/dbus.inc b/meta/recipes-core/dbus/dbus.inc
> index fb5d017..f975dc9 100644
> --- a/meta/recipes-core/dbus/dbus.inc
> +++ b/meta/recipes-core/dbus/dbus.inc
> @@ -39,13 +39,13 @@ CONFFILES_${PN} = "${sysconfdir}/dbus-1/system.conf ${sysconfdir}/dbus-1/session
>  
>  DEBIANNAME_${PN} = "dbus-1"
>  
> -PACKAGES =+ "${PN}-lib"
> +PACKAGES =+ "${PN}-lib ${PN}-tools"
>  
>  OLDPKGNAME = "dbus-x11"
>  OLDPKGNAME_class-nativesdk = ""
>  
>  # for compatibility
> -RPROVIDES_${PN} = "${OLDPKGNAME}"
> +RPROVIDES_${PN} = "${OLDPKGNAME} ${PN}-native-tools-native"

this line seems to be wrong. What are you trying to solve with it?

Regards,
Andreas

>  RREPLACES_${PN} += "${OLDPKGNAME}"
>  
>  FILES_${PN} = "${bindir}/dbus-daemon* \
> @@ -64,6 +64,12 @@ FILES_${PN} = "${bindir}/dbus-daemon* \
>  FILES_${PN}-lib = "${libdir}/lib*.so.*"
>  RRECOMMENDS_${PN}-lib = "${PN}"
>  FILES_${PN}-dev += "${libdir}/dbus-1.0/include ${bindir}/dbus-glib-tool"
> +FILES_${PN}-tools += "${bindir}/dbus-uuidgen \
> +                      ${bindir}/dbus-cleanup-sockets \
> +                      ${bindir}/dbus-monitor \
> +                      ${bindir}/dbus-launch \
> +                      ${bindir}/dbus-run-session"
> +RRECOMMENDS_${PN} = "${PN}-tools"
>  
>  pkg_postinst_dbus() {
>  	# If both systemd and sysvinit are enabled, mask the dbus-1 init script
>