From: Saul Wold <sgw@linux.intel.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v2] openssl: fix libssl.pc to use libcrypto
Date: Tue, 17 Mar 2015 11:55:34 -0600 [thread overview]
Message-ID: <55086A96.7060505@linux.intel.com> (raw)
In-Reply-To: <C27BBC55-806F-40DE-8CE4-1A43F8B975C5@gmail.com>
On 03/16/2015 07:48 PM, Khem Raj wrote:
>
>> On Mar 16, 2015, at 6:35 PM, Saul Wold <sgw@linux.intel.com> wrote:
>>
>> The 1.0.2 version of libssl requires that libcrypto be linked so don't
>> keep it private anymore.
>>
>> Signed-off-by: Saul Wold <sgw@linux.intel.com>
>> ---
>> .../openssl/fix_Makefile_creation_of_libssl.patch | 16 ++++++++++++++++
>> meta/recipes-connectivity/openssl/openssl_1.0.2.bb | 1 +
>> 2 files changed, 17 insertions(+)
>> create mode 100644 meta/recipes-connectivity/openssl/openssl/fix_Makefile_creation_of_libssl.patch
>>
>> diff --git a/meta/recipes-connectivity/openssl/openssl/fix_Makefile_creation_of_libssl.patch b/meta/recipes-connectivity/openssl/openssl/fix_Makefile_creation_of_libssl.patch
>> new file mode 100644
>> index 0000000..e76ab2e
>> --- /dev/null
>> +++ b/meta/recipes-connectivity/openssl/openssl/fix_Makefile_creation_of_libssl.patch
>> @@ -0,0 +1,16 @@
>> +Upstream-Status: Pending
>> +Signed-off-by: Saul Wold <sgw@linux.intel.com>
>> +
>> +Index: openssl-1.0.2/Makefile.org
>> +===================================================================
>> +--- openssl-1.0.2.orig/Makefile.org
>> ++++ openssl-1.0.2/Makefile.org
>> +@@ -381,7 +381,7 @@ libssl.pc: Makefile
>> + echo 'Description: Secure Sockets Layer and cryptography libraries'; \
>> + echo 'Version: '$(VERSION); \
>> + echo 'Requires.private: libcrypto'; \
>> +- echo 'Libs: -L$${libdir} -lssl'; \
>> ++ echo 'Libs: -L$${libdir} -lssl -lcrypto'; \
>
> There must be a reason why upstream changed it to be private. What is the reason ?
> since reverting like this can have consequences, we need to understand this.
>
Ok drop this patch, it means that we need to fix the openflow recipe
since it really is using APIs from both libssl and libcrypto which can
be summed up by using the openssl.pc instead of trying to just use
libssl.pc which was used because of history in openflow.
Patches to meta-oe will be forth coming for openflow to use openssl.pc
and a pyopenssl upgrade.
Sorry for the noise here.
Sau!
>> + echo 'Libs.private: $(EX_LIBS)'; \
>> + echo 'Cflags: -I$${includedir} $(KRB5_INCLUDES)' ) > libssl.pc
>> +
>> diff --git a/meta/recipes-connectivity/openssl/openssl_1.0.2.bb b/meta/recipes-connectivity/openssl/openssl_1.0.2.bb
>> index 79537f9..a980855 100644
>> --- a/meta/recipes-connectivity/openssl/openssl_1.0.2.bb
>> +++ b/meta/recipes-connectivity/openssl/openssl_1.0.2.bb
>> @@ -37,6 +37,7 @@ SRC_URI += "file://configure-targets.patch \
>> file://Makefiles-ptest.patch \
>> file://ptest-deps.patch \
>> file://run-ptest \
>> + file://fix_Makefile_creation_of_libssl.patch \
>> "
>>
>> SRC_URI[md5sum] = "38373013fc85c790aabf8837969c5eba"
>> --
>> 2.1.0
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>
>
prev parent reply other threads:[~2015-03-17 17:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 1:35 [PATCH v2] openssl: fix libssl.pc to use libcrypto Saul Wold
2015-03-17 1:48 ` Khem Raj
2015-03-17 17:55 ` Saul Wold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55086A96.7060505@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox