From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.windriver.com (mail.windriver.com [147.11.1.11]) by mail.openembedded.org (Postfix) with ESMTP id 8C08060043 for ; Thu, 2 Apr 2015 05:09:33 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail.windriver.com (8.14.9/8.14.9) with ESMTP id t3259Xor002851 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Wed, 1 Apr 2015 22:09:33 -0700 (PDT) Received: from [128.224.162.174] (128.224.162.174) by ALA-HCA.corp.ad.wrs.com (147.11.189.40) with Microsoft SMTP Server id 14.3.224.2; Wed, 1 Apr 2015 22:09:33 -0700 Message-ID: <551CCF0C.60207@windriver.com> Date: Thu, 2 Apr 2015 13:09:32 +0800 From: Robert Yang User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Martin Jansa References: <711934cddbc4f8c699487c16e33715cd9a6d5a57.1427874748.git.liezhi.yang@windriver.com> <20150401175949.GL14928@jama> <551CB39B.1000500@windriver.com> <20150402043746.GN14928@jama> In-Reply-To: <20150402043746.GN14928@jama> Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH 3/3] glibc: fix a tpo X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Apr 2015 05:09:36 -0000 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit On 04/02/2015 12:37 PM, Martin Jansa wrote: > On Thu, Apr 02, 2015 at 11:12:27AM +0800, Robert Yang wrote: >> >> >> On 04/02/2015 01:59 AM, Martin Jansa wrote: >>> On Wed, Apr 01, 2015 at 12:53:02AM -0700, Robert Yang wrote: >>>> Fixed a typo: >>>> name-target-directory -> make-target-directory >>> >>> You have another typo in commit message. >> >> Sorry, I checked again, which typo, please ? > > "fix a TPO" Ah, yes, thanks, I updated it in the repo. git://git.openembedded.org/openembedded-core-contrib rbt/3fixes // Robert > >> // Robert >> >>> >>>> There is no name-target-directory, it should be make-target-directory, >>>> this fixed the error: >>>> /bin/bash: /path/to/elf/runtime-linker.T: No such file or directory >>>> Makefile:361: recipe for target '/path/to/elf/runtime-linker.st' failed >>>> >>>> Signed-off-by: Robert Yang >>>> --- >>>> .../glibc/glibc/elf-Makefile-fix-a-typo.patch | 36 ++++++++++++++++++++ >>>> meta/recipes-core/glibc/glibc_2.21.bb | 1 + >>>> 2 files changed, 37 insertions(+) >>>> create mode 100644 meta/recipes-core/glibc/glibc/elf-Makefile-fix-a-typo.patch >>>> >>>> diff --git a/meta/recipes-core/glibc/glibc/elf-Makefile-fix-a-typo.patch b/meta/recipes-core/glibc/glibc/elf-Makefile-fix-a-typo.patch >>>> new file mode 100644 >>>> index 0000000..ec48006 >>>> --- /dev/null >>>> +++ b/meta/recipes-core/glibc/glibc/elf-Makefile-fix-a-typo.patch >>>> @@ -0,0 +1,36 @@ >>>> +From 6207fb45553ee98f2f326883b7c21b76c8267343 Mon Sep 17 00:00:00 2001 >>>> +From: Robert Yang >>>> +Date: Tue, 31 Mar 2015 02:31:25 -0700 >>>> +Subject: [PATCH] elf/Makefile: fix a typo >>>> + >>>> +Fixed a typo: >>>> +name-target-directory -> make-target-directory >>>> + >>>> +There is no name-target-directory, it should be make-target-directory, >>>> +this fixed the error: >>>> +/bin/bash: /path/to/elf/runtime-linker.T: No such file or directory >>>> +Makefile:361: recipe for target '/path/to/elf/runtime-linker.st' failed >>>> + >>>> +Upstream-Status: Pending >>>> + >>>> +Signed-off-by: Robert Yang >>>> +--- >>>> + elf/Makefile | 2 +- >>>> + 1 file changed, 1 insertion(+), 1 deletion(-) >>>> + >>>> +diff --git a/elf/Makefile b/elf/Makefile >>>> +index e5b142c..62fe245 100644 >>>> +--- a/elf/Makefile >>>> ++++ b/elf/Makefile >>>> +@@ -358,7 +358,7 @@ $(objpfx)interp.os: $(elf-objpfx)runtime-linker.h >>>> + >>>> + $(elf-objpfx)runtime-linker.h: $(elf-objpfx)runtime-linker.st; @: >>>> + $(elf-objpfx)runtime-linker.st: $(common-objpfx)config.make >>>> +- $(name-target-directory) >>>> ++ $(make-target-directory) >>>> + echo '#define RUNTIME_LINKER "$(rtlddir)/$(rtld-installed-name)"' \ >>>> + > ${@:st=T} >>>> + $(move-if-change) ${@:st=T} ${@:st=h} >>>> +-- >>>> +1.7.9.5 >>>> + >>>> diff --git a/meta/recipes-core/glibc/glibc_2.21.bb b/meta/recipes-core/glibc/glibc_2.21.bb >>>> index 91feff5..fcef4ff 100644 >>>> --- a/meta/recipes-core/glibc/glibc_2.21.bb >>>> +++ b/meta/recipes-core/glibc/glibc_2.21.bb >>>> @@ -25,6 +25,7 @@ SRC_URI = "git://sourceware.org/git/glibc.git;branch=${BRANCH} \ >>>> file://0001-Add-unused-attribute.patch \ >>>> file://0001-When-disabling-SSE-also-make-sure-that-fpmath-is-not.patch \ >>>> file://0001-yes-within-the-path-sets-wrong-config-variables.patch \ >>>> + file://elf-Makefile-fix-a-typo.patch \ >>>> ${EGLIBCPATCHES} \ >>>> " >>>> EGLIBCPATCHES = "\ >>>> -- >>>> 1.7.9.5 >>>> >>>> -- >>>> _______________________________________________ >>>> Openembedded-core mailing list >>>> Openembedded-core@lists.openembedded.org >>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core >>> >