From: Khem Raj <raj.khem@gmail.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH 24/53] directfb: Fix build with musl
Date: Fri, 8 Jan 2016 10:18:52 +0000 [thread overview]
Message-ID: <555844c65d44169bb4478d4470a802ebc2fe2f94.1452248145.git.raj.khem@gmail.com> (raw)
In-Reply-To: <604bc7909e229178e6723a5323f99ae33cf7ec7f.1452248145.git.raj.khem@gmail.com>
In-Reply-To: <cover.1452248145.git.raj.khem@gmail.com>
compar_fn_t, sigval_t and non-posix recursive mutexes
are not available in musl
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
meta/recipes-graphics/directfb/directfb.inc | 5 ++
.../directfb/directfb/compar_fn_t.patch | 62 ++++++++++++++++++++++
.../directfb/directfb/union-sigval.patch | 19 +++++++
.../directfb/use-PTHREAD_MUTEX_RECURSIVE.patch | 19 +++++++
4 files changed, 105 insertions(+)
create mode 100644 meta/recipes-graphics/directfb/directfb/compar_fn_t.patch
create mode 100644 meta/recipes-graphics/directfb/directfb/union-sigval.patch
create mode 100644 meta/recipes-graphics/directfb/directfb/use-PTHREAD_MUTEX_RECURSIVE.patch
diff --git a/meta/recipes-graphics/directfb/directfb.inc b/meta/recipes-graphics/directfb/directfb.inc
index 603aba3..3a79a8f 100644
--- a/meta/recipes-graphics/directfb/directfb.inc
+++ b/meta/recipes-graphics/directfb/directfb.inc
@@ -16,7 +16,12 @@ SRC_URI = "http://www.directfb.org/downloads/Core/DirectFB-1.7/DirectFB-${PV}.ta
file://fusion.patch \
file://bashism.patch \
file://0001-gfx-direct-Aboid-usng-VLAs-and-printf-formats.patch \
+ file://compar_fn_t.patch \
"
+SRC_URI_append_libc-musl = "\
+ file://union-sigval.patch \
+ file://use-PTHREAD_MUTEX_RECURSIVE.patch \
+ "
S = "${WORKDIR}/DirectFB-${PV}"
diff --git a/meta/recipes-graphics/directfb/directfb/compar_fn_t.patch b/meta/recipes-graphics/directfb/directfb/compar_fn_t.patch
new file mode 100644
index 0000000..ee4d900
--- /dev/null
+++ b/meta/recipes-graphics/directfb/directfb/compar_fn_t.patch
@@ -0,0 +1,62 @@
+test for __compar_fn_t and if not defined by libc then define it
+help make directfb compile with musl
+
+Upstream-Status: Pending
+Signed-off-by: Khem Raj <raj.khem@gmail.com>
+
+Index: DirectFB-1.7.7/configure.in
+===================================================================
+--- DirectFB-1.7.7.orig/configure.in
++++ DirectFB-1.7.7/configure.in
+@@ -112,6 +112,17 @@ AC_CHECK_SIZEOF(long)
+ AC_CHECK_SIZEOF(long long)
+ AC_CHECK_FUNCS(fork)
+
++AC_CACHE_CHECK([for compar_fn_t in stdlib.h],ccache_cv_COMPAR_FN_T, [
++ AC_TRY_COMPILE(
++ [#include <stdlib.h>],
++ [void test_fn(void) { qsort(NULL, 0, 0, (__compar_fn_t)NULL); }],
++ ccache_cv_COMPAR_FN_T=yes,
++ ccache_cv_COMPAR_FN_T=no)])
++if test x"$ccache_cv_COMPAR_FN_T" = x"yes"; then
++ AC_DEFINE(HAVE_COMPAR_FN_T, 1,
++ Define to 1 if you have the `__compar_fn_t' typedef.)
++fi
++
+ AC_PATH_PROGS(PERL, perl5 perl)
+
+ AC_PATH_PROG(MAN2HTML, man2html, no)
+Index: DirectFB-1.7.7/inputdrivers/lirc/lirc.c
+===================================================================
+--- DirectFB-1.7.7.orig/inputdrivers/lirc/lirc.c
++++ DirectFB-1.7.7/inputdrivers/lirc/lirc.c
+@@ -59,6 +59,11 @@
+
+ #include <core/input_driver.h>
+
++#if HAVE_COMPAR_FN_T
++#define COMPAR_FN_T __compar_fn_t
++#else
++typedef int (*COMPAR_FN_T)(const void *, const void *);
++#endif
+
+ DFB_INPUT_DRIVER( lirc )
+
+@@ -97,7 +102,7 @@ static DFBInputDeviceKeySymbol lirc_pars
+ qsort ( keynames,
+ D_ARRAY_SIZE( keynames ),
+ sizeof(keynames[0]),
+- (__compar_fn_t) keynames_sort_compare );
++ (COMPAR_FN_T) keynames_sort_compare );
+ keynames_sorted = true;
+ }
+
+@@ -124,7 +129,7 @@ static DFBInputDeviceKeySymbol lirc_pars
+ symbol_name = bsearch( name, keynames,
+ D_ARRAY_SIZE( keynames ),
+ sizeof(keynames[0]),
+- (__compar_fn_t) keynames_compare );
++ (COMPAR_FN_T) keynames_compare );
+ if (symbol_name)
+ return symbol_name->symbol;
+ break;
diff --git a/meta/recipes-graphics/directfb/directfb/union-sigval.patch b/meta/recipes-graphics/directfb/directfb/union-sigval.patch
new file mode 100644
index 0000000..29f45c7
--- /dev/null
+++ b/meta/recipes-graphics/directfb/directfb/union-sigval.patch
@@ -0,0 +1,19 @@
+This patch is taken from gentoo musl overlay
+sigval_t is glibc only construct, we use a union of sigval
+which pretty much is same effect as sigval_t
+
+Upstream-Status: Pending
+Signed-off-by: Khem Raj <raj.khem@gmail.com>
+
+diff -Naur DirectFB-1.7.6.orig/lib/direct/os/linux/glibc/system.c DirectFB-1.7.6/lib/direct/os/linux/glibc/system.c
+--- DirectFB-1.7.6.orig/lib/direct/os/linux/glibc/system.c 2014-07-15 02:54:58.000000000 -0400
++++ DirectFB-1.7.6/lib/direct/os/linux/glibc/system.c 2015-07-18 16:55:35.077989166 -0400
+@@ -111,7 +111,7 @@
+ void
+ direct_trap( const char *domain, int sig )
+ {
+- sigval_t val;
++ union sigval val;
+
+ if (direct_config->delay_trap_ms) {
+ D_LOG( Direct_Trap, VERBOSE, "NOT RAISING signal %d from %s, waiting for %dms... attach gdb --pid=%d\n", sig, domain, direct_config->delay_trap_ms, getpid() );
diff --git a/meta/recipes-graphics/directfb/directfb/use-PTHREAD_MUTEX_RECURSIVE.patch b/meta/recipes-graphics/directfb/directfb/use-PTHREAD_MUTEX_RECURSIVE.patch
new file mode 100644
index 0000000..e65f59e
--- /dev/null
+++ b/meta/recipes-graphics/directfb/directfb/use-PTHREAD_MUTEX_RECURSIVE.patch
@@ -0,0 +1,19 @@
+This patch is taken from gentoo musl overlay
+uses recursive mutex directly instead of non-posix version
+
+Upstream-Status: Pending
+Signed-off-by: Khem Raj <raj.khem@gmail.com>
+
+
+diff -Naur DirectFB-1.7.6.orig/lib/direct/os/linux/glibc/mutex.h DirectFB-1.7.6/lib/direct/os/linux/glibc/mutex.h
+--- DirectFB-1.7.6.orig/lib/direct/os/linux/glibc/mutex.h 2013-12-18 19:16:24.000000000 -0500
++++ DirectFB-1.7.6/lib/direct/os/linux/glibc/mutex.h 2015-07-18 16:57:47.178982835 -0400
+@@ -46,7 +46,7 @@
+ /**********************************************************************************************************************/
+
+ #define DIRECT_MUTEX_INITIALIZER(name) { PTHREAD_MUTEX_INITIALIZER }
+-#define DIRECT_RECURSIVE_MUTEX_INITIALIZER(name) { PTHREAD_RECURSIVE_MUTEX_INITIALIZER_NP }
++#define DIRECT_RECURSIVE_MUTEX_INITIALIZER(name) { PTHREAD_MUTEX_RECURSIVE }
+
+ #endif
+
--
2.7.0
next prev parent reply other threads:[~2016-01-08 10:19 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 10:19 [PATCH 00/53] musl fixes 3 Khem Raj
2016-01-08 10:18 ` [PATCH 01/53] powertop: Include right headers for timval struct Khem Raj
2016-01-08 10:18 ` [PATCH 02/53] dhcp: Include sys/types.h for u_int* defs Khem Raj
2016-01-08 10:18 ` [PATCH 03/53] blktrace: Include <sys/types.h for dev_t Khem Raj
2016-01-08 10:18 ` [PATCH 04/53] ppp: Fix build with musl Khem Raj
2016-01-08 10:18 ` [PATCH 05/53] tcp-wrappers: " Khem Raj
2016-01-08 10:18 ` [PATCH 06/53] fts: Add recipe Khem Raj
2016-01-08 10:18 ` [PATCH 07/53] connman: include config.h for HAVE_STRUCT_IN6_PKTINFO_IPI6_ADDR Khem Raj
2016-01-08 10:18 ` [PATCH 08/53] libcgroup: Add dependency on fts when building on musl Khem Raj
2016-01-08 10:18 ` [PATCH 09/53] linux-libc-headers: Port patches for linux-headers for musl Khem Raj
2016-01-08 10:18 ` [PATCH 10/53] xserver-xorg: Fix build with musl Khem Raj
2016-01-08 10:18 ` [PATCH 11/53] gdk-pixbuf: Fix latent build issue exposed by musl Khem Raj
2016-01-08 10:18 ` [PATCH 12/53] argp-standalone: Add recipe Khem Raj
2016-01-08 10:18 ` [PATCH 13/53] gnutls: Link with libargp on musl and depend on argp-standalone Khem Raj
2016-01-08 10:18 ` [PATCH 14/53] util-linux: Fix ptest builds on musl Khem Raj
2016-01-08 10:18 ` [PATCH 15/53] webkitgtk: Fix build with clang Khem Raj
2016-01-08 10:18 ` [PATCH 16/53] elfutils: Fix build with uclibc Khem Raj
2016-01-08 10:18 ` [PATCH 17/53] packagegroup-self-hosted.bb: Move glibc-gconv-ibm850 to glibc only case Khem Raj
2016-01-08 10:18 ` [PATCH 18/53] guile: Fix build with uclibc Khem Raj
2016-01-08 10:18 ` [PATCH 19/53] gnutls: Link with libuargp on uclibc Khem Raj
2016-01-08 10:18 ` [PATCH 20/53] mtools: Fix build with uclibc Khem Raj
2016-01-08 16:17 ` Burton, Ross
2016-01-08 16:25 ` Burton, Ross
2016-01-08 17:27 ` Khem Raj
2016-01-08 10:18 ` [PATCH 21/53] parted: " Khem Raj
2016-01-08 10:18 ` [PATCH 22/53] net-tools: Link with libintl on uclibc Khem Raj
2016-01-08 10:18 ` [PATCH 23/53] libdrm: Upgrade 2.4.65 -> 2.4.66 Khem Raj
2016-01-08 10:18 ` Khem Raj [this message]
2016-01-09 3:27 ` [PATCH 24/53] directfb: Fix build with musl Andre McCurdy
2016-01-09 7:43 ` Khem Raj
2016-01-09 8:43 ` Khem Raj
2016-01-09 9:58 ` Burton, Ross
2016-01-08 10:18 ` [PATCH 25/53] gzip: " Khem Raj
2016-01-08 10:18 ` [PATCH 26/53] watchdog: " Khem Raj
2016-01-08 10:18 ` [PATCH 27/53] xinetd: " Khem Raj
2016-01-08 10:18 ` [PATCH 28/53] dpkg: Add musleabi to known architectures Khem Raj
2016-01-08 10:18 ` [PATCH 29/53] puzzles: Zero'ise structs before use Khem Raj
2016-01-08 10:18 ` [PATCH 30/53] Revert "glib-2.0: build dependency cleanup" Khem Raj
2016-01-08 10:39 ` Burton, Ross
2016-01-08 17:36 ` Khem Raj
2016-01-08 10:18 ` [PATCH 31/53] apt: Add support for building for musl targets Khem Raj
2016-01-08 10:19 ` [PATCH 32/53] libunwind: backtrace APIs are glibc specific Khem Raj
2016-01-08 10:19 ` [PATCH 33/53] babeltrace: Add missing header for MAXNAMLEN define Khem Raj
2016-01-08 10:19 ` [PATCH 34/53] elfutils: Fix build with musl Khem Raj
2016-01-08 10:19 ` [PATCH 35/53] sysklogd: untangle header inclusion maze Khem Raj
2016-01-08 10:19 ` [PATCH 36/53] console-tools: Include sys/types.h for u_char and u_short defs Khem Raj
2016-01-08 10:19 ` [PATCH 37/53] webkitgtk: Fix build on non-glibc linux systems Khem Raj
2016-01-08 10:19 ` [PATCH 38/53] rt-tests: Fix build with non-gcc compilers Khem Raj
2016-01-08 10:19 ` [PATCH 39/53] webkitgtk: Update patch status Khem Raj
2016-01-08 10:19 ` [PATCH 40/53] tar: Fix build for musl based targets Khem Raj
2016-01-08 10:19 ` [PATCH 41/53] net-tools: Fix build on musl Khem Raj
2016-01-08 10:19 ` [PATCH 42/53] pax: Fix build with musl Khem Raj
2016-01-08 10:19 ` [PATCH 43/53] iputils: " Khem Raj
2016-01-08 10:19 ` [PATCH 44/53] libuser: Fix build when secure getenv is not there Khem Raj
2016-01-08 10:19 ` [PATCH 45/53] iproute2: Fix build with musl Khem Raj
2016-01-08 10:19 ` [PATCH 46/53] irda-utils: Fix header inclusions Khem Raj
2016-01-08 10:19 ` [PATCH 47/53] nspr: Drop older glibc code Khem Raj
2016-01-08 10:19 ` [PATCH 48/53] chkconfig: Avoid using caddr_t Khem Raj
2016-01-08 10:19 ` [PATCH 49/53] tcf-agent: Implement canonicalize_file_name() for musl as well Khem Raj
2016-01-08 10:19 ` [PATCH 50/53] bsd-headers, musl: Add recipe for bsd missing features Khem Raj
2016-01-08 10:19 ` [PATCH 51/53] nfs-utils: Disable tcp-wrappers for musl Khem Raj
2016-01-08 10:19 ` [PATCH 52/53] portmap: Point to tirpc headers and libraries on musl Khem Raj
2016-01-08 10:19 ` [PATCH 53/53] elfutils: Add ALLOW_EMPTY for musl Khem Raj
2016-01-08 10:58 ` [PATCH 00/53] musl fixes 3 Burton, Ross
2016-01-08 14:00 ` Burton, Ross
2016-01-08 14:12 ` Burton, Ross
2016-01-08 14:23 ` Burton, Ross
2016-01-08 17:46 ` Khem Raj
2016-01-08 14:32 ` Burton, Ross
2016-01-08 17:47 ` Khem Raj
2016-01-08 14:53 ` Burton, Ross
2016-01-08 17:57 ` Khem Raj
2016-01-09 9:23 ` Khem Raj
2016-01-09 10:06 ` Burton, Ross
2016-01-08 17:43 ` Khem Raj
2016-01-08 18:29 ` Burton, Ross
2016-01-08 18:34 ` Khem Raj
2016-01-09 8:59 ` Khem Raj
2016-01-08 14:56 ` Burton, Ross
2016-01-08 17:59 ` Khem Raj
2016-01-10 21:10 ` Khem Raj
2016-01-10 21:29 ` Matthias Schiffer
2016-01-10 22:22 ` Phil Blundell
2016-01-10 22:24 ` Paul Eggleton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555844c65d44169bb4478d4470a802ebc2fe2f94.1452248145.git.raj.khem@gmail.com \
--to=raj.khem@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox