From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mail.openembedded.org (Postfix) with ESMTP id DCB9B60962 for ; Mon, 18 May 2015 19:16:59 +0000 (UTC) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP; 18 May 2015 12:17:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,454,1427785200"; d="scan'208";a="573243451" Received: from alimon-thinkpad-w540.zpn.intel.com (HELO [10.219.4.36]) ([10.219.4.36]) by orsmga003.jf.intel.com with ESMTP; 18 May 2015 12:17:00 -0700 Message-ID: <555A3AF5.7000807@linux.intel.com> Date: Mon, 18 May 2015 14:18:13 -0500 From: =?UTF-8?B?QW7DrWJhbCBMaW3Ds24=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: openembedded-core@lists.openembedded.org References: <1431976573-15545-1-git-send-email-anibal.limon@linux.intel.com> In-Reply-To: <1431976573-15545-1-git-send-email-anibal.limon@linux.intel.com> Subject: Re: [PATCH] license_class: Add explicity avoid of CLOSED license in validations X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 May 2015 19:17:00 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sorry i forget to put [FIDO] suffix. Regards, alimon On 18/05/15 14:16, Aníbal Limón wrote: > The CLOSED license isn't a generic license it is a set and can > be any closed source license. > > [YOCTO #7752] > > Signed-off-by: Aníbal Limón > --- > meta/classes/license.bbclass | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/meta/classes/license.bbclass b/meta/classes/license.bbclass > index 73a0e97..fdc1170 100644 > --- a/meta/classes/license.bbclass > +++ b/meta/classes/license.bbclass > @@ -71,6 +71,11 @@ license_create_manifest() { > > lics="$(echo ${pkged_lic} | sed "s/[|&()*]/ /g" | sed "s/ */ /g" )" > for lic in ${lics}; do > + # add explicity avoid of CLOSED license because isn't generic > + if [ "$lic" = "CLOSED" ]; then > + continue > + fi > + > # to reference a license file trim trailing + symbol > if ! [ -e "${LICENSE_DIRECTORY}/${pkged_pn}/generic_${lic%+}" ]; then > bbwarn "The license listed ${lic} was not in the licenses collected for ${pkged_pn}" > @@ -242,8 +247,10 @@ def find_license_files(d): > > lic_files_paths.append(("generic_" + license_type, os.path.join(license_source, spdx_generic))) > else: > - # And here is where we warn people that their licenses are lousy > - bb.warn("%s: No generic license file exists for: %s in any provider" % (pn, license_type)) > + # Add explicity avoid of CLOSED license because this isn't generic > + if license_type != 'CLOSED': > + # And here is where we warn people that their licenses are lousy > + bb.warn("%s: No generic license file exists for: %s in any provider" % (pn, license_type)) > pass > > if not generic_directory: