From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.windriver.com (mail.windriver.com [147.11.1.11]) by mail.openembedded.org (Postfix) with ESMTP id 8709965D19 for ; Wed, 20 May 2015 02:17:49 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail.windriver.com (8.14.9/8.14.9) with ESMTP id t4K2Hg8j003939 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Tue, 19 May 2015 19:17:44 -0700 (PDT) Received: from [128.224.163.153] (128.224.163.153) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server (TLS) id 14.3.224.2; Tue, 19 May 2015 19:17:41 -0700 Message-ID: <555BEED0.2010909@windriver.com> Date: Wed, 20 May 2015 10:17:52 +0800 From: ChenQi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Christopher Larson , Richard Purdie References: <971f18fc4a97344769e54313a78898f86f520a7e.1432024013.git.Qi.Chen@windriver.com> <1432032474.32616.25.camel@linuxfoundation.org> In-Reply-To: X-Originating-IP: [128.224.163.153] Cc: Patches and discussions about the oe-core layer Subject: Re: [PATCH 1/1] buildstats-summary: add eventmask X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 May 2015 02:17:52 -0000 Content-Type: multipart/alternative; boundary="------------020508050903080803000307" --------------020508050903080803000307 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit On 05/19/2015 09:40 PM, Christopher Larson wrote: > > On Tue, May 19, 2015 at 3:47 AM, Richard Purdie > > wrote: > > On Tue, 2015-05-19 at 16:29 +0800, Chen Qi wrote: > > Add eventmask for buildstats_summary handler. > > Why? > > This says what you've done but not why we need this... > > Cheers, > > Richard > > > Also, this adds the eventmask, but doesn’t remove the then-redundant > isinstance() on the event object. Hi Richard and Christopher, Thanks for you advice. I'll send out V2. Regards, Chen Qi > -- > Christopher Larson > clarson at kergoth dot com > Founder - BitBake, OpenEmbedded, OpenZaurus > Maintainer - Tslib > Senior Software Engineer, Mentor Graphics --------------020508050903080803000307 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
On 05/19/2015 09:40 PM, Christopher Larson wrote:

On Tue, May 19, 2015 at 3:47 AM, Richard Purdie <richard.purdie@linuxfoundation.org> wrote:
On Tue, 2015-05-19 at 16:29 +0800, Chen Qi wrote:
> Add eventmask for buildstats_summary handler.

Why?

This says what you've done but not why we need this...

Cheers,

Richard

Also, this adds the eventmask, but doesn’t remove the then-redundant isinstance() on the event object.

Hi Richard and Christopher,

Thanks for you advice.
I'll send out V2.

Regards,
Chen Qi

--
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics

--------------020508050903080803000307--