From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail1.windriver.com (mail1.windriver.com [147.11.146.13]) by mail.openembedded.org (Postfix) with ESMTP id 40D86757E8 for ; Wed, 3 Jun 2015 00:57:04 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail1.windriver.com (8.15.1/8.15.1) with ESMTPS id t530v6UC016837 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Tue, 2 Jun 2015 17:57:06 -0700 (PDT) Received: from [128.224.162.136] (128.224.162.136) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.3.224.2; Tue, 2 Jun 2015 17:57:06 -0700 Message-ID: <556E50E0.4010000@windriver.com> Date: Wed, 3 Jun 2015 08:57:04 +0800 From: Rongqing Li User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: "Burton, Ross" References: <1431476040-29583-1-git-send-email-rongqing.li@windriver.com> <556BB753.10808@windriver.com> <556E4F97.7000004@windriver.com> In-Reply-To: <556E4F97.7000004@windriver.com> Cc: OE-core Subject: Re: [PATCH][V3] mmc-utils: fix the building failure when DEBUG_BUILD is 1 X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Jun 2015 00:57:05 -0000 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit On 2015年06月03日 08:51, Rongqing Li wrote: > > > On 2015年06月02日 18:38, Burton, Ross wrote: >> >> On 1 June 2015 at 02:37, Rongqing Li > > wrote: >> >> +EXTRA_OEMAKE = 'AM_CFLAGS="-D_FILE_OFFSET_BITS=64"' >> >> >> This seems fragile as you're relying on future maintainers checking that >> upstream don't change the value of AM_CFLAGS. Would passing >> -U_FORTIFY_SOURCE via CPPFLAGS solve the problem in a neater way? >> >> Ross > > > what should I do? make a patch which remove _FORTIFY_SOURCE from > AM_CFLAGS in > Makefile? > > I see what you said Thanks -R > -Roy > > > -- Best Reagrds, Roy | RongQing Li