Re: [PATCH] alsa-tools: add dependency glib-2.0

[Jack Mitchell <ml@communistcode.co.uk>]

On 05/06/15 02:50, Kang Kai wrote:
> On 2015年06月04日 17:23, Jack Mitchell wrote:
>> On 04/06/15 06:57, Kai Kang wrote:
>>> Add dependency glib-2.0 for alsa-tools. It is required by new added
>>> sub-component hdajacksensetest.
>>>
>>> Signed-off-by: Kai Kang <kai.kang@windriver.com>
>>> ---
>>>   meta/recipes-multimedia/alsa/alsa-tools_1.0.29.bb | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/meta/recipes-multimedia/alsa/alsa-tools_1.0.29.bb 
>>> b/meta/recipes-multimedia/alsa/alsa-tools_1.0.29.bb
>>> index 9133012..b5b9cc4 100644
>>> --- a/meta/recipes-multimedia/alsa/alsa-tools_1.0.29.bb
>>> +++ b/meta/recipes-multimedia/alsa/alsa-tools_1.0.29.bb
>>> @@ -3,7 +3,7 @@ HOMEPAGE = "http://www.alsa-project.org"
>>>   BUGTRACKER = 
>>> "https://bugtrack.alsa-project.org/alsa-bug/login_page.php"
>>>   SECTION = "console/utils"
>>>   LICENSE = "GPLv2 & LGPLv2+"
>>> -DEPENDS = "alsa-lib ncurses"
>>> +DEPENDS = "alsa-lib ncurses glib-2.0"
>>>     LIC_FILES_CHKSUM = 
>>> "file://hdsploader/COPYING;md5=94d55d512a9ba36caa9b7df079bae19f \
>>> file://ld10k1/COPYING.LIB;md5=7fbc338309ac38fefcd64b04bb903e34"
>>
>> It would be nice to put this behind a hdajacksensetest packageconfig 
>> if possible.
>
> The hdajacksensetest is just a sub-directory/component not a feature, 
> and it can't be built without library glib.
> If make it as a package config, we have to find a way to remove 
> hdajacksensetes. I suppose it is not proper to
> add it as a packageconfig.
>
> BTW, the dependency on glib-2.0 for alsa-tools is passed by depending 
> on gtk+3 if 'x11' in distro feauture. If without 'x11',
> not such dependency, then build hdajacksensetest fails. So add 
> 'glib-2.0' to DEPENDS.
>
> Thanks,
>

Ok, it's just quite a heavy dependancy for a package which is feasible 
to be installed on very small systems; as you have proved by glib-2.0 
not beiing available in a non-x11 build. In this case I guess the way 
round it would be to split out the alsa-tools packages, but that is also 
a lot of work. The patch is fine and I don't use alsa-tools so I have no 
strong feelings; I just like to keep and eye on and question bloat.

Cheers,