From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mail.openembedded.org (Postfix) with ESMTP id 7224660557 for ; Tue, 16 Jun 2015 18:20:59 +0000 (UTC) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 16 Jun 2015 11:21:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,627,1427785200"; d="scan'208";a="712129245" Received: from unknown (HELO [10.218.100.102]) ([10.218.100.102]) by orsmga001.jf.intel.com with ESMTP; 16 Jun 2015 11:21:00 -0700 To: Andreas Oberritter , Bruno Bottazzini , openembedded-core@lists.openembedded.org References: <1431553871-23972-1-git-send-email-bruno.bottazzini@intel.com> <1431553871-23972-4-git-send-email-bruno.bottazzini@intel.com> <5553D30E.9010201@opendreambox.org> From: Leandro Dorileo Message-ID: <5580690B.9070908@intel.com> Date: Tue, 16 Jun 2015 15:20:59 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <5553D30E.9010201@opendreambox.org> Subject: Re: [PATCH V5 3/3] systemd: split modules into packages X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jun 2015 18:21:00 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 05/13/2015 07:41 PM, Andreas Oberritter wrote: > Hello Bruno, > > On 13.05.2015 23:51, Bruno Bottazzini wrote: >> +######################################################################## >> +# Aggregation of Split Packages >> +######################################################################## >> +PACKAGES =+ "${PN}-services-base" >> +SUMMARY_${PN}-services-base = "Base services aggregation" >> +ALLOW_EMPTY_${PN}-services-base = "1" >> +RDEPENDS_${PN}-services-base = " \ > > I think it would be better to use RRECOMMENDS, in order to support > BAD_RECOMMENDATIONS per image. This would also remove the need to use > bb.utils.contains, because unavailable recommended packages get ignored > by the package managers. In the end, isn't it just a different approach? a different way of doing the same thing? By the way, from my point of view, semantically we're saying "we want a given package feature" besides the "we want a given distro feature", don't you think? > > Besides that, I wonder whether ${PN}-services would be a better name, > because the -base suffix suggests that it contained only the most > important services. Ok, here I agree. Bruno, could you please do the rename suggested here by Andreas? > > Btw., sorry for commenting late again, but it's quite a big patch. > > Regards, > Andreas > >> + ${@bb.utils.contains('PACKAGECONFIG', 'ask-password', '${PN}-services-ask-password', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'backlight', '${PN}-services-backlight', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'binfmt', '${PN}-services-binfmt', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'dbus', '${PN}-services-dbus', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'firstboot', '${PN}-services-firstboot', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'fuse', '${PN}-services-fuse', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'quota', '${PN}-services-quota', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'rfkill', '${PN}-services-rfkill', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'timesyncd', '${PN}-services-timesyncd', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'update', '${PN}-services-update', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'vconsole', '${PN}-services-vconsole', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'filesystems', '${PN}-generators-filesystems', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'preset', '${PN}-preset', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'fsck', '${PN}-services-fsck', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'journal', '${PN}-services-journal', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'modules-load', '${PN}-services-modules-load', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'randomseed', '${PN}-services-randomseed', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'sleep', '${PN}-services-sleep', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'sysctl', '${PN}-services-sysctl', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'sysusers', '${PN}-services-sysusers', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'tmpfiles', '${PN}-services-tmpfiles', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'udev', '${PN}-services-udev', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'tools', '${PN}-tools', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'bash', '${PN}-bash', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'initramfs', '${PN}-initramfs', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'kernel-install', '${PN}-kernel-install', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'rpm-macros', '${PN}-rpm-macros', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'zsh', '${PN}-zsh', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'bootchart', '${PN}-services-bootchart', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'debug', '${PN}-services-debug', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'machined', '${PN}-services-machined', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'nspawn', '${PN}-services-nspawn', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'sysvcompat', '${PN}-services-sysvcompat', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'getty', '${PN}-generators-getty', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'getty', '${PN}-services-getty', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'ldconfig', '${PN}-services-ldconfig', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'polkit', '${PN}-services-hostnamed', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'polkit', '${PN}-services-localed', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'polkit', '${PN}-services-logind', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'polkit', '${PN}-services-timedated', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'pam', '${PN}-pam', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'networkd', '${PN}-services-networkd', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'microhttpd', '${PN}-services-networkd', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'microhttpd', '${PN}-services-journal-gatewayd', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'cryptsetup', '${PN}-services-cryptsetup', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'gudev', 'udev-dbg', '', d)} \ >> + ${@bb.utils.contains('PACKAGECONFIG', 'x11', '${PN}-services-multi-seat-x', '', d)} \ >> +" >