Re: [PATCH] ICU: libicudata corrupt on big endian systems

[Stefano Babic <sbabic@denx.de>]

Hi Paul,

On 17/06/2015 19:28, Paul Eggleton wrote:

>> @@ -0,0 +1,35 @@
>> +From 1878e1bfcd116dd3ed9519dd891bf18f860072b7 Mon Sep 17 00:00:00 2001
>> +From: Stefano Babic <sbabic@denx.de>
>> +Date: Thu, 4 Jun 2015 17:53:30 +0200
>> +Subject: [PATCH] target
> 
> 
> This needs a proper patch comment explaining what it's supposed to do and 
> Upstream-Status (probably "Inappropriate" here I guess).

Sure, I'll do

>> +SRC_URI_append_class-native = "${@base_conditional('TUNE_ARCH', 'powerpc',
>> 'file://native_big_endian.patch', '', d)}" 
> 
> It doesn't change the behaviour here, but it's good practice to ensure that 
> there is at least a space between any previous item and the item you are 
> appending - so I would recommend including a leading space either before 
> file:// or before the ${@ (or you could follow the SRC_URI_append_class-target 
> example on the next line).

Thanks, I'll fix it in V2.

Regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================