Re: [PATCH 1/1] sanity.bbclass: check /bin/sh is dash or bash

[Robert Yang <liezhi.yang@windriver.com>]

On 06/29/2015 11:06 AM, Robert Yang wrote:
>
>
> On 06/26/2015 09:10 PM, Burton, Ross wrote:
>>
>> On 26 June 2015 at 07:23, Robert Yang <liezhi.yang@windriver.com
>> <mailto:liezhi.yang@windriver.com>> wrote:
>>
>>     The build would fail when /bin/sh links to ksh or csh, we only test dash
>>     and bash AFAIK.
>>
>>
>> csh definitely isn't a suitable candidate for /bin/sh, and I doubt ksh is too.
>> Are people really doing this? They're just wrong...  I seriously doubt Linux
>> would boot with /bin/sh->csh and ksh would be asking for trouble.
>
> Hi Ross,
>
> Yes, Ubuntu would not boot well when /bin/sh -> ksh or csh, I just took
> them as an example, I think that we only test on bash or dash, so I
> think that this checking can reduce the potential errors, and I think
> that we also need check SHELL, I will test and send another patch.

I confirmed that the build is OK when set SHELL to /bin/ksh or /bin/csh,
so we don't have to check SHELL.

>
> // Robert
>
>>
>> Was this a real world problem, or a hypothetical problem?
>>
>> Ross