Re: [PATCH] tune-i586-nlp: Add new tune file to support Quark/X1000 CPU

[Darren Hart <dvhart@linux.intel.com>]

On 6/29/15 7:10 AM, Saul Wold wrote:
> This tune file is needed to enable a GAS option specific to this cpu family
> in order to disable the usage of lock prefix instructions.
> 
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> ---
>  meta/conf/machine/include/tune-i586-nlp.inc | 19 +++++++++++++++++++++++++++++
>  1 file changed, 19 insertions(+)
>  create mode 100644 meta/conf/machine/include/tune-i586-nlp.inc
> 
> diff --git a/meta/conf/machine/include/tune-i586-nlp.inc b/meta/conf/machine/include/tune-i586-nlp.inc
> new file mode 100644
> index 0000000..94e22c1
> --- /dev/null
> +++ b/meta/conf/machine/include/tune-i586-nlp.inc
> @@ -0,0 +1,19 @@
> +# Settings for the GCC(1) cpu-type "quark":
> +#
> +#
> +#
> +DEFAULTTUNE ?= "i586-nlp-32"
> +
> +# Include the previous tune to pull in PACKAGE_EXTRA_ARCHS
> +require conf/machine/include/x86/arch-x86.inc
> +
> +# x86 with no lock prefix
> +TUNEVALID[i586-nlp] = "IA32 with Lock Prefix omitted"
> +TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "i586-nlp", " -march=i586 -Wa,-momit-lock-prefix=yes", "", d)}"
> +
> +# Quark tune feature
> +AVAILTUNES = "i586-nlp-32"
> +TUNE_FEATURES_tune-i586-nlp-32 = "${TUNE_FEATURES_tune-x86} i586-nlp"
> +BASE_LIB_tune-i586-nlp-32 = "lib"
> +TUNE_PKGARCH_tune-i586-nlp-32 = "i586-nlp-32"
> +PACKAGE_EXTRA_ARCHS_tune-i586-nlp-32 = "i586-nlp-32"
> 

I believe this explicit assignment, instead of appending to tune-i586,
addresses the issue Phil raised?

Reviewed-by: Darren Hart <dvhart@linux.intel.com>

-- 
Darren Hart
Intel Open Source Technology Center