From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail1.windriver.com (mail1.windriver.com [147.11.146.13]) by mail.openembedded.org (Postfix) with ESMTP id 1E9B275870 for ; Tue, 14 Jul 2015 03:12:02 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail1.windriver.com (8.15.1/8.15.1) with ESMTPS id t6E3Bx1O007189 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Mon, 13 Jul 2015 20:12:00 -0700 (PDT) Received: from [128.224.162.200] (128.224.162.200) by ALA-HCA.corp.ad.wrs.com (147.11.189.40) with Microsoft SMTP Server id 14.3.235.1; Mon, 13 Jul 2015 20:11:58 -0700 Message-ID: <55A47DFD.9080902@windriver.com> Date: Tue, 14 Jul 2015 11:11:57 +0800 From: Robert Yang User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: zhangxiao , Christopher Larson References: <1436767810-20932-1-git-send-email-xiao.zhang@windriver.com> <55A46390.2090904@windriver.com> <55A46F99.1080606@windriver.com> In-Reply-To: <55A46F99.1080606@windriver.com> Cc: Patches and discussions about the oe-core layer Subject: Re: [PATCH] logrotate: move binary logrotate back to /usr/sbin X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jul 2015 03:12:03 -0000 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit On 07/14/2015 10:10 AM, zhangxiao wrote: > On 2015年07月14日 09:47, Christopher Larson wrote: >> >> On Mon, Jul 13, 2015 at 6:19 PM, zhangxiao > > wrote: >> >> On 2015年07月13日 22:28, Christopher Larson wrote: >> >> >> On Sun, Jul 12, 2015 at 11:10 PM, Zhang Xiao >> >> > >> wrote: >> >> Upstream-Status: pending >> >> Signed-off-by: Zhang Xiao > >> > >> >> >> >> There’s no info on why this is being done, only what’s being >> done, in >> this commit message. >> >> >> Binary logrotate should be installed in /usr/sbin and int fact, at >> the very >> beginning, it was there. While with commit a46d3646a3e1781be44: >> ... >> logrotate: obey our flags >> >> Needed to quiet GNU_HASH warnings, and some minor fixes. >> ... >> >> Part of its modification as below: >> ... >> - oe_runmake install DESTDIR=${D} PREFIX=${D} MANDIR=${mandir} >> + oe_runmake install DESTDIR=${D} PREFIX=${D} MANDIR=${mandir} >> BINDIR=${bindir} >> ... >> moves it to /usr/bin. It is not correct, so move it back to >> /usr/sbin with ${sbindir}. >> >> >> That’s entirely reasonable, but at least some reference to that needs to >> be in the commit message, not just email discussion :) > > So, How about: > > Commit a46d36 moves logrotate to /usr/bin by mistake. Fix it. I think that you can your last email as the commit message: Binary logrotate should be installed in /usr/sbin, at the very beginning, it was there. While with commit a46d3646a3e1781be44: ... logrotate: obey our flags Needed to quiet GNU_HASH warnings, and some minor fixes. ... Part of its modification as below: ... - oe_runmake install DESTDIR=${D} PREFIX=${D} MANDIR=${mandir} + oe_runmake install DESTDIR=${D} PREFIX=${D} MANDIR=${mandir} BINDIR=${bindir} ... moves it to /usr/bin. It is not correct, so move it back to /usr/sbin with ${sbindir}. // Robert > > Thanks > Xiao >> -- >> Christopher Larson >> clarson at kergoth dot com >> Founder - BitBake, OpenEmbedded, OpenZaurus >> Maintainer - Tslib >> Senior Software Engineer, Mentor Graphics