From: Rongqing Li <rongqing.li@windriver.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH][resend] perl: fix build failure if building dir has the "blib" string
Date: Wed, 29 Jul 2015 11:08:17 +0800 [thread overview]
Message-ID: <55B843A1.6040207@windriver.com> (raw)
In-Reply-To: <CAJTo0La-RwRf3L-sJ=HtMMFi_nMQwXi5cXzunELAg6trRyT0cw@mail.gmail.com>
On 2015年07月28日 20:53, Burton, Ross wrote:
>
> On 27 July 2015 at 02:01, Rongqing Li <rongqing.li@windriver.com
> <mailto:rongqing.li@windriver.com>> wrote:
>
> I think we can merge this patch.
>
> I open a defect and submit this patch, as a result, noone knows
> what this line can fix.
>
>
> https://rt.perl.org/Public/Bug/Display.html?id=125603
>
>
> Reading the bug it seems a more upstream-friendly fix (i.e. one that
> they would also accept and have in fact asked for) would be to change
> the regex to /\bblib\b/. This solves the problem of building in paths
> that contain the substring "blib" *and* retains the intent of the logic.
>
it can not fix all issues to replace /blib/ with /\bblib\b/.
/\bblib\b/ will make the building path "/tmp/xxxxblibyy/" work.
but if the building path has sub-dir blib, it does not work,
like /tmp/blib/
since \b is anchor in perl
I have update the perl bug report
https://rt.perl.org/Public/Bug/Display.html?id=125603
-R
> Ross
--
Best Reagrds,
Roy | RongQing Li
next prev parent reply other threads:[~2015-07-29 3:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 8:54 [PATCH][resend] perl: fix build failure if building dir has the "blib" string rongqing.li
2015-07-10 9:09 ` Jens Rehsack
2015-07-10 9:28 ` Rongqing Li
2015-07-10 10:08 ` Jens Rehsack
2015-07-13 2:11 ` Rongqing Li
2015-07-10 9:39 ` Jussi Kukkonen
2015-07-27 1:01 ` Rongqing Li
2015-07-28 12:53 ` Burton, Ross
2015-07-29 3:08 ` Rongqing Li [this message]
2015-07-29 13:25 ` Burton, Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B843A1.6040207@windriver.com \
--to=rongqing.li@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox