From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.windriver.com (mail.windriver.com [147.11.1.11]) by mail.openembedded.org (Postfix) with ESMTP id 0A41F601F7 for ; Wed, 29 Jul 2015 09:11:36 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail.windriver.com (8.15.1/8.15.1) with ESMTPS id t6T9BW85006659 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Wed, 29 Jul 2015 02:11:32 -0700 (PDT) Received: from [128.224.162.218] (128.224.162.218) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.3.235.1; Wed, 29 Jul 2015 02:11:15 -0700 To: Paul Eggleton References: <1438156108-3973-1-git-send-email-yongming.yang@windriver.com> <3536050.hMERRFrlJT@peggleto-mobl.ger.corp.intel.com> From: Firo Yang Message-ID: <55B898C6.6070305@windriver.com> Date: Wed, 29 Jul 2015 17:11:34 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <3536050.hMERRFrlJT@peggleto-mobl.ger.corp.intel.com> Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH] image: Fix a build error by adding kernel dependence to do_rootfs X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jul 2015 09:11:39 -0000 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit On 07/29/2015 04:50 PM, Paul Eggleton wrote: > Hi Firo, > > On Wednesday 29 July 2015 15:48:28 Firo Yang wrote: >> Issue: LIN7-4290 >> >> do_rootfs needs a file named kernel-abiversion generated by >> virtual/kernel:do_packagedata to run depmod. >> >> If do_rootfs scheduled before virtual/kernel:do_packagedata that will >> make do_roofs failed because of leaking the file kernel-abiversion. >> So add the dependence of virtual/kernel:do_packagedata to do_rootfs >> will make it happier. >> >> Signed-off-by: Firo Yang >> --- >> meta/classes/image.bbclass | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass >> index ed12abb..b6128da 100644 >> --- a/meta/classes/image.bbclass >> +++ b/meta/classes/image.bbclass >> @@ -77,7 +77,7 @@ LDCONFIGDEPEND_libc-uclibc = "" >> LDCONFIGDEPEND_libc-musl = "" >> >> do_rootfs[depends] += "makedevs-native:do_populate_sysroot >> virtual/fakeroot-native:do_populate_sysroot ${LDCONFIGDEPEND}" >> -do_rootfs[depends] += >> "virtual/update-alternatives-native:do_populate_sysroot >> update-rc.d-native:do_populate_sysroot" +do_rootfs[depends] += >> "virtual/update-alternatives-native:do_populate_sysroot >> update-rc.d-native:do_populate_sysroot virtual/kernel:do_packagedata" >> do_rootfs[recrdeptask] += "do_packagedata" >> >> def command_variables(d): > This was already fixed some time ago: > > http://cgit.openembedded.org/openembedded-core/commit/?id=41f0f86ec0a3e0b6f6c9bb4ef71a4215c00bf66c > > And modified slightly since then: > > http://cgit.openembedded.org/openembedded-core/commit/?id=2e3c8fd70694dcf9553b5e4c50a57b617a9130b6 > > If you could please ensure future patches you send are against the > master branch, that would be much appreciated. Hi Paul Thanks for your kind reply. I will do more check before sending patches next time. Best, Firo > > Thanks, > Paul >