Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Alexander Kanavin <alexander.kanavin@linux.intel.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [meta-oe][PATCH] dosfstools-2.11: Fix memory leak in mkdosfs
Date: Thu, 06 Aug 2015 12:12:35 +0300	[thread overview]
Message-ID: <55C32503.3050800@linux.intel.com> (raw)
In-Reply-To: <1438851969-4340-1-git-send-email-amarnath.valluri@intel.com>

On 08/06/2015 12:06 PM, Amarnath Valluri wrote:
> Added new patch that fixes the memory leak that was introduced in
> mkdosfs-dir.patch.

You should update the original patch then, not pile additional patches 
on top. The least painful way is:

1) unpack the sources (manually from tarball, or using bitbake -c unpack)
2) 'git init; git add *; git commit' to create an git repository from 
the sources
3) apply the patch that needs fixing, then do the fix
4) make a git commit, then produce a patch using git format-patch, then 
move the new patch back to the recipe directory and update the recipe
5) build the recipe to make sure it still builds
6) make a git commit with the recipe update, and submit it here :)

Alex



  reply	other threads:[~2015-08-06  9:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-06  9:06 [meta-oe][PATCH] dosfstools-2.11: Fix memory leak in mkdosfs Amarnath Valluri
2015-08-06  9:12 ` Alexander Kanavin [this message]
2015-08-06  9:25   ` Paul Eggleton
2015-08-06 12:17     ` Valluri, Amarnath
2015-08-07  2:52     ` Khem Raj
2015-08-07  9:51       ` Paul Eggleton
2015-08-07 19:26         ` Khem Raj
2015-08-07 19:54           ` Paul Eggleton
2015-08-08 18:54             ` Khem Raj
2015-08-09 16:21               ` Paul Eggleton
2015-08-09 17:03                 ` Khem Raj
2015-08-09 21:30                   ` Paul Eggleton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55C32503.3050800@linux.intel.com \
    --to=alexander.kanavin@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox