Re: [PATCH] kernel-yocto: do_configme: Add $TOOLCHAIN_OPTIONS to CFLAGS

[Ioan-Adrian Ratiu <adrian.ratiu@ni.com>]

On 06.08.2015 16:19, Bruce Ashfield wrote:
> On Thu, Aug 6, 2015 at 3:23 AM, Ioan-Adrian Ratiu <adrian.ratiu@ni.com> wrote:
>> On 05.08.2015 16:50, Bruce Ashfield wrote:
>>>
>>> On Wed, Aug 5, 2015 at 4:39 AM, Adrian Ratiu <adrian.ratiu@ni.com> wrote:
>>>>
>>>> Bruce Ashfield <bruce.ashfield@gmail.com> wrote on 05.08.2015 05:17:14:
>>>>
>>>>> On Tue, Aug 4, 2015 at 4:41 AM, Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
>>>>> wrote:
>>>>>>
>>>>>> The kernel configure step was broken by the sysroot poisoning in [1].
>>>>>
>>>>>
>>>>> Can you be more precise here ? Configuration certainly works for me ..
>>>>> and
>>>>> has been working since last October.
>>>>
>>>>
>>>> This works because it was fixed in linux-yocto.inc *after* the sysroot
>>>> poisoning.
>>>> I've mentioned this in the next line :) But this is not what this fix is
>>>> for,
>>>> this fix should have been done at the same time with adding
>>>> $TOOLCHAIN_OPTIONS
>>>> to $KERNEL_CC in linux-yocto.inc.
>>>>
>>>> This bug was missed because there is NO error reporting in
>>>> yocto-kernel-tools
>>>> merge_configs.sh and the build continues despite the error. I've sent a
>>>> patch to
>>>> fail loudly in case merge_configs.sh fails in yocto-kernel-tools. You
>>>> know
>>>> about
>>>> it because you responded to that mail :) These issues are related.
>>>
>>>
>>> right. And as you saw there .. I don't need that patch. So we might as
>>> well
>>> let this one sit as well.
>>
>>
>> It's great if these issues were already fixed somehow different than how I
>> proposed. Are those local changes pushed to a public branch yet? I would
>> really like to test the new code.
>
> The solution is similar in the end, I just came to adding extra error checking
> via a different route (missing .cfg fragments not being reported and stopping
> the build).
>
> They are unfortunately back on my development machine, and I'm on
> vacation at the moment. But I will be back near that equipment next
> week!

I still think that we are solving two different issues altogether with 
these patches, but I think it best we wait until you push your changes 
and after that (if need be) I will reapply my patches on top of your 
changes and resend (again, if need be).

Have a nice vacation!