Re: [PATCH 2/4] python3: remove package python3-robotparser

["Dominic Sacré" <dominic.sacre@gmx.de>]

On 2015-08-09 03:02, Khem Raj wrote:
>> On Jul 28, 2015, at 7:58 AM, Dominic Sacré <dominic.sacre@gmx.de> wrote:
>>
>> robotparser has been moved to urllib.robotparser in Python 3, and gets
>> packaged as part of python3-netclient alongside the rest of urllib.
>> This causes python3-modules to depend on an empty/missing
>> python3-robotparser package.
>>
>> robotparser.py is relatively small and has no dependencies outside
>> urllib, so it makes more sense to eliminate the python3-robotparser
>> package than to alter the manifest for python3-netclient.
>>
>> Part of the fix for [YOCTO #8048].
>>
>> Signed-off-by: Dominic Sacré <dominic.sacre@gmx.de>
>> ---
>> meta/recipes-devtools/python/python-3.4-manifest.inc | 10 +++-------
>> scripts/contrib/python/generate-manifest-3.4.py      |  3 ---
>> 2 files changed, 3 insertions(+), 10 deletions(-)
>>
>> diff --git a/meta/recipes-devtools/python/python-3.4-manifest.inc b/meta/recipes-devtools/python/python-3.4-manifest.inc
>> index 557acdf..77f0125 100644
>> --- a/meta/recipes-devtools/python/python-3.4-manifest.inc
>> +++ b/meta/recipes-devtools/python/python-3.4-manifest.inc
> 
> this file is auto generated. So did you regenerate it ?

The changes to scripts/contrib/python/generate-manifest-3.4.py are
included in the same patch:

>> diff --git a/scripts/contrib/python/generate-manifest-3.4.py b/scripts/contrib/python/generate-manifest-3.4.py
>> index 569fd3c..42c851c 100755
>> --- a/scripts/contrib/python/generate-manifest-3.4.py
>> +++ b/scripts/contrib/python/generate-manifest-3.4.py
>> @@ -343,9 +343,6 @@ if __name__ == "__main__":
>>     m.addPackage( "${PN}-shell", "Python shell-like functionality", "${PN}-core ${PN}-re",
>>     "cmd.* commands.* dircache.* fnmatch.* glob.* popen2.* shlex.* shutil.*" )
>>
>> -    m.addPackage( "${PN}-robotparser", "Python robots.txt parser", "${PN}-core ${PN}-netclient",
>> -    "urllib/robotparser.*")
>> -
>>     m.addPackage( "${PN}-subprocess", "Python subprocess support", "${PN}-core ${PN}-io ${PN}-re ${PN}-fcntl ${PN}-pickle",
>>     "subprocess.*" )

I ran the modified script to update python-3.4-manifest.inc, then
added both files to my commit. Is there something I've missed?


Dominic