Re: [PATCH 2/2] base.bbclass/blacklist.bbclass: remove doc item when d.getVarFlags()

[Robert Yang <liezhi.yang@windriver.com>]

On 08/11/2015 08:45 PM, Otavio Salvador wrote:
> On Thu, Jul 30, 2015 at 12:18 PM, Robert Yang <liezhi.yang@windriver.com> wrote:
>> The FOO[doc] is set in meta/conf/documentation.conf, we need remove it
>> from d.getVarFlags()'s return dict when it causes many loops.
>>
>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>
> It seems your commit log is incomplete or so as I couldn't understand
> why this is need.
>
> Also as Andre says, we ought to not break existing layer without a
> very strong reason and if needed, changing documentation.conf instead
> of this seems more adequate.
>

The code in base.bbclass is: (no remove PACKAGECONFIG[doc])

     pkgconfigflags = d.getVarFlags("PACKAGECONFIG") or {}
     if pkgconfigflags:
        <foo>

And documentation.conf:
PACKAGECONFIG[doc] = "This variable provides a means of enabling or disabling 
features of a recipe on a per-recipe basis."

This will make "if pkgconfigflags:" always be true and cause many unneeded
loops since there is always PACKAGECONFIG[doc].

Remove PACKAGECONFIG[doc] or comment it sounds good to me.

// Robert