From: Robert Yang <liezhi.yang@windriver.com>
To: Randy MacLeod <randy.macleod@windriver.com>,
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/3] toolchain-shar-extract.sh: add a space in the end
Date: Mon, 17 Aug 2015 10:27:43 +0800 [thread overview]
Message-ID: <55D1469F.4020708@windriver.com> (raw)
In-Reply-To: <55CE9496.6040401@windriver.com>
On 08/15/2015 09:23 AM, Randy MacLeod wrote:
> Nit pick on logs...
>
> In the short log:
> s/add a space in the end/
> /Add a space after asking a question/
>
> On 2015-08-13 03:37 AM, Robert Yang wrote:
>> For a clear look when input.
> This is a sentence fragment. It will read better if you repeat yourself:
>
> Add a space at the end of a line when asking a question.
> This makes it easier to read.
Thanks, I will update it.
// Robert
>
> ../Randy
>>
>> [YOCTO #8089]
>>
>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>> ---
>> meta/files/toolchain-shar-extract.sh | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/files/toolchain-shar-extract.sh
>> b/meta/files/toolchain-shar-extract.sh
>> index 0a33ee8..3a50991 100644
>> --- a/meta/files/toolchain-shar-extract.sh
>> +++ b/meta/files/toolchain-shar-extract.sh
>> @@ -92,11 +92,11 @@ fi
>>
>> if [ -e "$target_sdk_dir/environment-setup-@REAL_MULTIMACH_TARGET_SYS@" ]; then
>> echo "The directory \"$target_sdk_dir\" already contains a SDK for this
>> architecture."
>> - printf "If you continue, existing files will be overwritten! Proceed[y/N]?"
>> + printf "If you continue, existing files will be overwritten! Proceed[y/N]? "
>>
>> default_answer="n"
>> else
>> - printf "You are about to install the SDK to \"$target_sdk_dir\".
>> Proceed[Y/n]?"
>> + printf "You are about to install the SDK to \"$target_sdk_dir\".
>> Proceed[Y/n]? "
>>
>> default_answer="y"
>> fi
>>
>
>
next prev parent reply other threads:[~2015-08-17 2:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-13 7:37 [PATCH 0/3] populate_sdk_base.bbclass: fixes for multilib sdk Robert Yang
2015-08-13 7:37 ` [PATCH 1/3] toolchain-shar-extract.sh: add a space in the end Robert Yang
2015-08-15 1:23 ` Randy MacLeod
2015-08-17 2:27 ` Robert Yang [this message]
2015-08-13 7:37 ` [PATCH 2/3] populate_sdk_base.bbclass: help rpm to pull in multilib toolchain Robert Yang
2015-08-15 8:55 ` Richard Purdie
2015-08-17 2:27 ` Robert Yang
2015-08-13 7:37 ` [PATCH 3/3] packagegroup-core-standalone-sdk-target: remove qemuwrapper-cross Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D1469F.4020708@windriver.com \
--to=liezhi.yang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=randy.macleod@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox