Re: [PATCH 2/3] insane.bbclass: add host-user-contaminated test

[Joshua Lock <joshua.lock@collabora.co.uk>]

On 26/08/15 15:20, Christopher Larson wrote:
>
> On Wed, Aug 26, 2015 at 7:19 AM, Christopher Larson <clarson@kergoth.com
> <mailto:clarson@kergoth.com>> wrote:
>
>     On Wed, Aug 26, 2015 at 4:01 AM, Burton, Ross <ross.burton@intel.com
>     <mailto:ross.burton@intel.com>> wrote:
>
>         On 26 August 2015 at 09:44, Joshua Lock
>         <joshua.lock@collabora.co.uk
>         <mailto:joshua.lock@collabora.co.uk>> wrote:
>
>             I do all of my builds on a separate partition in a directory
>             hierarchy which is owned by my user - if I'm understanding
>             this correctly I'll get QA WARNINGS for all of my builds
>             with this change?
>
>
>         The paths are prefixed with ${D} so pretend the commit log says
>         "in packages".
>
>
>     Heh, indeed, it's a package QA test. do_install runs under pseudo,
>     so any newly created files there, or files chown'd to root, will be
>     fine. If, however, a recipe does a cp -a or so to install without
>     doing a chown, you'll end up with files in your rootfs owned by the
>     user that did the build -- not good.

Indeed. Thanks for taking the time to clarify.

>
> I can re-submit with that commit message clarification, if needed? I
> rather thought the fact that it was in insane.bbclass, not
> sanity.bbclass, carried the necessary implication.

Personally I don't feel that's necessary - I should review with more 
care (and coffee).

Thanks for the offer though.

Regards,

Joshua