Re: [PATCH 1/3] package_rpm: support signing of rpm packages

[Mark Hatle <mark.hatle@windriver.com>]

[-- Attachment #1: Type: text/plain, Size: 993 bytes --]

On 8/26/15 10:11 PM, Markus Lehtonen wrote:
>> Without pasting the whole patch:
>>
>> --- createrepo-0.4.11.orig/dumpMetadata.py
>> +++ createrepo-0.4.11/dumpMetadata.py
>> @@ -92,7 +92,7 @@ def returnHdr(ts, package):
>> -    ts.setVSFlags((rpm.RPMVSF_NOMD5|rpm.RPMVSF_NEEDPAYLOAD))
>> +
>> ts.setVSFlags((rpm.RPMVSF_NOMD5|rpm.RPMVSF_NEEDPAYLOAD|rpm.RPMVSF_NODSA|rp
>> m.RPMVSF_NORSA|rpm.RPMVSF_NODSAHEADER|rpm.RPMVSF_NORSAHEADER))
>>
>> I can send up this change if you think it's useful in this case (and would
>> eliminate these steps.)
> 
> I can introduce a separate patch in the next version of this patchset.
> 

The patch we use is attached.  (it's just a patch, not a proper git commit..)

> 
> 
>>
>> (The reason I question the steps is purely because we've seen in the past
>> these
>> temporary RPM databases seem to be fragile at times.  So anything we can
>> do to
>> avoid that is probably good.)
> 
> Yes.
> 
> 
> Thanks,
>   Markus
> 
> 


[-- Attachment #2: createrepo-skipsigned.patch --]
[-- Type: text/plain, Size: 1149 bytes --]

createrepo: Disable GPG signature validation

If the packages are signed, and the signature is not in the rpm-native
RPMDB, an error will occur.  We want to avoid this failure mode 
when building the native version of createrepo.

This only affects the feed generation and will not change any later
validations during use/install from the package feed.

Upstream-status: Inappropriate [no longer maintained version]

Signed-off-by: Mark Hatle <mark.hatle@windriver.com>

Index: createrepo-0.4.11/dumpMetadata.py
===================================================================
--- createrepo-0.4.11.orig/dumpMetadata.py
+++ createrepo-0.4.11/dumpMetadata.py
@@ -92,7 +92,7 @@ def returnHdr(ts, package):
             fdno = package # let's assume this is an fdno and go with it :)
     except OSError:
         raise MDError, "Error opening file"
-    ts.setVSFlags((rpm.RPMVSF_NOMD5|rpm.RPMVSF_NEEDPAYLOAD))
+    ts.setVSFlags((rpm.RPMVSF_NOMD5|rpm.RPMVSF_NEEDPAYLOAD|rpm.RPMVSF_NODSA|rpm.RPMVSF_NORSA|rpm.RPMVSF_NODSAHEADER|rpm.RPMVSF_NORSAHEADER))
     try:
         hdr = ts.hdrFromFdno(fdno)
     except rpm.error: