From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mail.openembedded.org (Postfix) with ESMTP id DCE9B77009 for ; Thu, 3 Sep 2015 21:54:07 +0000 (UTC) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP; 03 Sep 2015 14:54:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,464,1437462000"; d="scan'208";a="797796523" Received: from afshjern.zpn.intel.com (HELO [10.219.128.48]) ([10.219.128.48]) by fmsmga002.fm.intel.com with ESMTP; 03 Sep 2015 14:54:06 -0700 To: Martin Jansa References: <1441211805-17543-1-git-send-email-alejandro.franco@linux.intel.com> <1441216283.24871.78.camel@linuxfoundation.org> <20150902182548.GG2470@jama> <55E769B4.4050800@linux.intel.com> <55E8A710.6050003@linux.intel.com> <20150903214304.GA2456@jama> From: Alex Franco Message-ID: <55E8C1A1.20106@linux.intel.com> Date: Thu, 3 Sep 2015 16:54:41 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20150903214304.GA2456@jama> Cc: Christopher Larson , Patches and discussions about the oe-core layer Subject: Re: [PATCH] Fix recursive mode -st on BUILDDIR setup X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Sep 2015 21:54:08 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Yes, I agree and in fact the patch is just now shipping Alex Franco On 09/03/2015 04:43 PM, Martin Jansa wrote: > On Thu, Sep 03, 2015 at 03:01:20PM -0500, Alex Franco wrote: >> Hello Martin, so the error you are seeing is related to the chmodding >> being done in sanity.bbclass, not the chmodding taking place in >> oe-setup-builddir. I am adding a catch and a warning for that, as I >> reproduce your setup so I can also reproduce the OSError. > Thanks. > > My point was that even when such setup isn't safe from reasons other > people mentioned, the sanity.bbclass shouldn't fail with OSError > exception. > > And as the issue isn't fatal for the build (I was using setup like this > for very long time and haven't noticed host-permissions-contamination > from this yet), then I would prefer just bbwarn instead of bbfatal - in > both cases is should show clear message what's wrong and what user > should do about it instead of OSError and user having to read > sanity.bbclass to see what and why failed. > > Regards, > >> Alex >> >> On 09/02/2015 07:57 PM, Martin Jansa wrote: >>> Warning informing that chmod failed is better than fatal error >>> preventing me to build anything in that setup with tmpfs. >>> >>> On Wed, Sep 2, 2015 at 11:27 PM, Alex Franco >>> >> > wrote: >>> >>> Checking may be the better approach, as warning here would do >>> little more than what the current failure does (informing that >>> chmod failed) >>> >>> Alex Franco >>> >>> >>> On 09/02/2015 01:25 PM, Martin Jansa wrote: >>> >>> On Wed, Sep 02, 2015 at 06:51:23PM +0100, Richard Purdie wrote: >>> >>> On Wed, 2015-09-02 at 11:36 -0500, Alex Franco wrote: >>> >>> Removing recursive option from chmod -st on BUILDDIR >>> as it would >>> take very long on existing build directories >>> >>> [YOCTO 7669] >>> >>> Signed-off-by: Alex Franco >>> >> > >>> --- >>> scripts/oe-setup-builddir | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/scripts/oe-setup-builddir >>> b/scripts/oe-setup-builddir >>> index f5b7e4e..44c7dcc 100755 >>> --- a/scripts/oe-setup-builddir >>> +++ b/scripts/oe-setup-builddir >>> @@ -24,7 +24,7 @@ if [ -z "$BUILDDIR" ]; then >>> fi >>> mkdir -p "$BUILDDIR/conf" >>> -chmod -R -st "$BUILDDIR" >>> +chmod -st "$BUILDDIR" >>> >>> I think you did this so that conf/ gets the right >>> permissions too. >>> Perhaps the best approach is: >>> >>> +chmod -st "$BUILDDIR" $BUILDDIR/conf" >>> >>> Can we add "|| bbwarn foo" >>> >>> for cases when it doesn't work for whatever reason or check the >>> permissions of these 2 dirs before calling chmod? >>> >>> ? >>> >>> Cheers, >>> >>> Richard >>> >>> -- >>> _______________________________________________ >>> Openembedded-core mailing list >>> Openembedded-core@lists.openembedded.org >>> >>> http://lists.openembedded.org/mailman/listinfo/openembedded-core >>> >>> >>>