Re: [PATCH 1/3] Empty image: core-image-empty recipe, Rootfs fix

[Alex Franco <alejandro.franco@linux.intel.com>]

Yes indeed! Sorry, I didn't see this before!

Alex

On 08/29/2015 06:18 AM, Paul Eggleton wrote:
> Hi Alex,
>
> On Wednesday 26 August 2015 16:57:33 Alex Franco wrote:
>> Added a core-image-empty recipe, as well as a DpkgOpkgRootfs test
>> which skips the package post installs step, if PACKAGE_INSTALL is
>> empty.
>>
>> [YOCTO #7664]
>>
>> Signed-off-by: Alex Franco <alejandro.franco@linux.intel.com>
>> ---
>>   meta/lib/oe/rootfs.py                        | 6 +++++-
>>   meta/recipes-core/images/core-image-empty.bb | 7 +++++++
>>   2 files changed, 12 insertions(+), 1 deletion(-)
>>   create mode 100644 meta/recipes-core/images/core-image-empty.bb
>>
>> diff --git a/meta/lib/oe/rootfs.py b/meta/lib/oe/rootfs.py
>> index 8c8244c..f8cc6eb 100644
>> --- a/meta/lib/oe/rootfs.py
>> +++ b/meta/lib/oe/rootfs.py
>> @@ -585,7 +585,11 @@ class DpkgOpkgRootfs(Rootfs):
>>
>>           pkg_list = []
>>
>> -        pkgs = self._get_pkgs_postinsts(status_file)
>> +        pkgs = None
>> +        if not self.d.getVar('PACKAGE_INSTALL', True).strip():
>> +            bb.note("Building empty image")
>> +        else:
>> +            pkgs = self._get_pkgs_postinsts(status_file)
>>           if pkgs:
>>               root = "__packagegroup_postinst__"
>>               pkgs[root] = pkgs.keys()
>> diff --git a/meta/recipes-core/images/core-image-empty.bb
>> b/meta/recipes-core/images/core-image-empty.bb new file mode 100644
>> index 0000000..550567c
>> --- /dev/null
>> +++ b/meta/recipes-core/images/core-image-empty.bb
>> @@ -0,0 +1,7 @@
>> +SUMMARY = "An empty image."
>> +IMAGE_INSTALL = ""
>> +IMAGE_LINGUAS = ""
>> +PACKAGE_INSTALL = ""
>> +LICENSE = "MIT"
>> +
>> +inherit image
> Could you please put this image recipe into meta-selftest instead (call it oe-
> selftest-empty-image.bb) and add an oe-selftest test to ensure it builds and
> is empty?
>
> Thanks,
> Paul
>