Re: [PATCH 1/2] connman: Depend on xuser-account unconditionally

[Andreas Oberritter <obi@opendreambox.org>]

Hello Jussi,

On 25.09.2015 13:14, Jussi Kukkonen wrote:
> This means dragging in xuser-account even when it's not used but
> that's a lesser evil than the recipe depending on machine specific
> settings.

that's quite ugly, sorry.

It's true that machine specific variables shouldn't be used in this
recipe, but adding privileged user accounts with regular home
directories is evil as well and confusing for real users.

There must be a better way to solve this.

Whether to add user accounts or not should be a decision made by the
distro. If this setting is machine specific, which to be honest
surprised me, why don't you just let the machine specific xorg video
driver depend on xuser-account unconditionally? Connman really doesn't
need this account.

> This also prevents a warning on connman service startup when
> ROOTLESS_X is not set:
>   Unknown username "xuser" in message bus
> 
> [YOCTO #8005]

This bugzilla entry is just about the warning, which could as well just
get ignored or removed from dbus.

Regards,
Andreas

> 
> Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com>
> ---
>  meta/recipes-connectivity/connman/connman.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-connectivity/connman/connman.inc b/meta/recipes-connectivity/connman/connman.inc
> index fd9640e..6c062ae 100644
> --- a/meta/recipes-connectivity/connman/connman.inc
> +++ b/meta/recipes-connectivity/connman/connman.inc
> @@ -113,7 +113,7 @@ RPROVIDES_${PN} = "\
>  
>  RDEPENDS_${PN} = "\
>  	dbus \
> -	${@base_conditional('ROOTLESS_X', '1', 'xuser-account', '', d)} \
> +	xuser-account \
>  	"
>  
>  PACKAGES_DYNAMIC += "^${PN}-plugin-.*"
>