public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Ross Burton <Ross.Burton@arm.com>
To: "pratik.farkase@est.tech" <pratik.farkase@est.tech>
Cc: "openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>,
	"pratik.farkase@ericsson.com" <pratik.farkase@ericsson.com>
Subject: Re: [OE-core][PATCH v3] libconfig: add ptest support
Date: Tue, 10 Feb 2026 12:13:38 +0000	[thread overview]
Message-ID: <56068E4F-CD6A-4E3D-A685-52994C77FFDF@arm.com> (raw)
In-Reply-To: <20260204145811.19113-1-pratik.farkase@est.tech>

Hi Patrik,

> On 4 Feb 2026, at 14:58, Pratik Farkase via lists.openembedded.org <pratik.farkase=est.tech@lists.openembedded.org> wrote:
> +do_install_ptest() {
> +    install -d ${D}${PTEST_PATH}/tests
> +
> +    if [ -f ${B}/tests/libconfig_tests ]; then
> +        ${B}/libtool --mode=install install -m 0755 ${B}/tests/libconfig_tests ${D}${PTEST_PATH}/tests/libconfig_tests
> +    fi
> +
> +    if [ -d ${S}/tests/testdata ]; then
> +        cp -r ${S}/tests/testdata ${D}${PTEST_PATH}/tests/
> +    fi
> +}

Same comments are before: don’t use conditions when installing or running the tests unless there’s a very good reason: we _want_ the build or tests to fail if things change.

(this one hasn’t merged, so please send a v4)

Thanks,
Ross


  reply	other threads:[~2026-02-10 12:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-28 14:06 [OE-core][PATCH v1] libconfig: add ptest support Pratik Farkase
2026-01-29  0:26 ` Randy MacLeod
2026-01-29  8:33   ` Pratik Farkase
2026-02-04 11:09     ` Alexander Kanavin
2026-02-04 12:02       ` Mathieu Dubois-Briand
2026-02-04 15:12       ` Pratik Farkase
2026-02-04 15:14         ` Alexander Kanavin
2026-02-04 15:16           ` Pratik Farkase
2026-02-04 15:18           ` Quentin Schulz
2026-01-29  8:30 ` [OE-core][PATCH v2] " Pratik Farkase
2026-02-04 14:58 ` [OE-core][PATCH v3] " Pratik Farkase
2026-02-10 12:13   ` Ross Burton [this message]
2026-02-10 18:54     ` Pratik Farkase
2026-02-10 20:41       ` Pratik Farkase
2026-02-10 18:47 ` [OE-core][PATCH v4] " Pratik Farkase
2026-02-10 20:39 ` [OE-core][PATCH v5] " Pratik Farkase

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56068E4F-CD6A-4E3D-A685-52994C77FFDF@arm.com \
    --to=ross.burton@arm.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=pratik.farkase@ericsson.com \
    --cc=pratik.farkase@est.tech \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox