Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Andreas Oberritter <obi@opendreambox.org>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] libepoxy: RDEPEND on libgl
Date: Fri, 2 Oct 2015 17:43:42 +0200	[thread overview]
Message-ID: <560EA62E.5020901@opendreambox.org> (raw)
In-Reply-To: <1443789718-6846-1-git-send-email-jussi.kukkonen@intel.com>

Hello Jussi,

On 02.10.2015 14:41, Jussi Kukkonen wrote:
> Automatic dependency tracking does not notice this (understandable
> with the dlopen trickery epoxy does).
> 
> [YOCTO #8371]
> 
> Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com>
> ---
> 
> 
> I'm not super familiar with the opengl handling so please let me know if there's some
> better way to do this: The problem being fixed is e.g. gtk3-demo failing to start
> because it fails to dlopen libGL.so.1.
> 
> 
>  meta/recipes-graphics/libepoxy/libepoxy_git.bb | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/recipes-graphics/libepoxy/libepoxy_git.bb b/meta/recipes-graphics/libepoxy/libepoxy_git.bb
> index ad17293..fe05d4e 100644
> --- a/meta/recipes-graphics/libepoxy/libepoxy_git.bb
> +++ b/meta/recipes-graphics/libepoxy/libepoxy_git.bb
> @@ -20,6 +20,7 @@ S = "${WORKDIR}/git"
>  inherit autotools pkgconfig
>  
>  DEPENDS = "util-macros virtual/egl"
> +RDEPENDS_${PN} = "libgl"
>  
>  PACKAGECONFIG[x11] = "--enable-glx, --disable-glx, virtual/libx11"

If epoxy behaves like other projects, then I'd try removing virtual/egl from
DEPENDS and replacing the line above with this one:

PACKAGECONFIG[x11] = "--enable-glx, --disable-glx, virtual/libx11 virtual/gl, libgl"

An additional packageconfig for gles2 should be added. For a rather complex
example covering many environments see meta/recipes-graphics/cogl/cogl-1.0.inc.

>  PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', '', d)}"

An empty default probably doesn't make sense for this library, unless --disable-glx
implies --enable-egl (or something similar). But then you'd need to keep the build
dependency on virtual/egl, even though it's most probably unused if x11 is available.

Regards,
Andreas


  parent reply	other threads:[~2015-10-02 15:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-02 12:41 [PATCH] libepoxy: RDEPEND on libgl Jussi Kukkonen
2015-10-02 12:48 ` Alexander Kanavin
2015-10-02 15:47   ` Andreas Oberritter
2015-10-02 15:43 ` Andreas Oberritter [this message]
2015-10-05 19:21   ` Burton, Ross
2015-10-06 15:12   ` Jussi Kukkonen
2015-10-09  7:19     ` Andreas Müller
2015-10-09  8:00       ` Jussi Kukkonen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=560EA62E.5020901@opendreambox.org \
    --to=obi@opendreambox.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox