From: Joshua Lock <joshua.lock@collabora.co.uk>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v2 4/7] systemd: make dbus an optional build time dependency
Date: Thu, 22 Oct 2015 16:01:41 +0100 [thread overview]
Message-ID: <5628FA55.8030507@collabora.co.uk> (raw)
In-Reply-To: <CAJTo0LZLoorMg6Jro+7GN0--hB8e4dFcxNNFLMcS6qTc5T9qrQ@mail.gmail.com>
On 21/10/15 17:09, Burton, Ross wrote:
>
> On 20 October 2015 at 10:47, Joshua Lock <joshua.lock@collabora.co.uk
> <mailto:joshua.lock@collabora.co.uk>> wrote:
>
> +PACKAGECONFIG[dbus] = "--enable-dbus,--disable-dbus,dbus"
>
>
> This also disables the code by default which is a change from the
> previous behaviour, which needs to be documented at least. Also as
> they're for the test suite, should we enable dbus by default if ptest is
> enabled?
Indeed, I'll submit a v3 which mentions this in the commit message.
Selfishly I'd rather we didn't enable it by default where ptest is enabled.
We'd like to push changes to build d-bus with systemd support by default
and to have dbus in the default DEPENDS would cause a dependency loop.
Of course if the feeling is that systemd with dbus tests in ptest is a
more useful default than dbus with systemd support, I can submit that
change.
Cheers,
Joshua
next prev parent reply other threads:[~2015-10-22 15:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 9:47 [PATCH v2 0/7] Various metadata tweaks v2 Joshua Lock
2015-10-20 9:47 ` [PATCH v2 1/7] systemd: add PACKAEGCONFIG to build with compatibility libraries Joshua Lock
2015-10-20 9:47 ` [PATCH v2 2/7] weston: backport support for single libsystemd.pc Joshua Lock
2015-10-20 9:47 ` [PATCH v2 3/7] weston: add PACKAGECONFIG to build with systemd-login support Joshua Lock
2015-10-21 16:14 ` Burton, Ross
2015-10-22 15:02 ` Joshua Lock
2015-10-20 9:47 ` [PATCH v2 4/7] systemd: make dbus an optional build time dependency Joshua Lock
2015-10-21 16:09 ` Burton, Ross
2015-10-22 15:01 ` Joshua Lock [this message]
2015-10-20 9:47 ` [PATCH v2 5/7] weston: add a PACKAGECONFIG option for xwayland support Joshua Lock
2015-10-20 9:47 ` [PATCH v2 6/7] xserver-xorg: add Xwayland RRECOMMENDS Joshua Lock
2015-10-20 9:47 ` [PATCH v2 7/7] xserver-xorg: drop empty ${PN}-security-policy package Joshua Lock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5628FA55.8030507@collabora.co.uk \
--to=joshua.lock@collabora.co.uk \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox