Re: [PATCH v2] util-linux: create util-linux-runuser package

[Mike Looijmans <mike.looijmans@topic.nl>]

On 10-11-15 09:50, Ioan-Adrian Ratiu wrote:
> Split runuser into its own package (previously provided by util-linux).
> Since runuser is compiled only when DISTRO_FEATURES includes pam,
> the creation of util-linux-runuser is also constrained by this.
>
> Signed-off-by: Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
> ---
>   meta/recipes-core/util-linux/util-linux.inc | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/util-linux/util-linux.inc b/meta/recipes-core/util-linux/util-linux.inc
> index 594108f..dc460e7 100644
> --- a/meta/recipes-core/util-linux/util-linux.inc
> +++ b/meta/recipes-core/util-linux/util-linux.inc
> @@ -34,6 +34,7 @@ PACKAGES =+ "util-linux-agetty util-linux-fdisk util-linux-cfdisk util-linux-sfd
>                util-linux-partx ${PN}-bash-completion util-linux-hwclock \
>                util-linux-findfs util-linux-getopt util-linux-sulogin"
>   PACKAGES += "${@bb.utils.contains('PACKAGECONFIG', 'pylibmount', 'util-linux-pylibmount', '', d)}"
> +PACKAGES =+ "${@bb.utils.contains('DISTRO_FEATURES', 'pam', 'util-linux-runuser', '', d)}"
>
>   PACKAGES_DYNAMIC = "^util-linux-lib.*"
>
> @@ -85,6 +86,7 @@ FILES_util-linux-partx = "${sbindir}/partx"
>   FILES_util-linux-hwclock = "${base_sbindir}/hwclock.${BPN}"
>   FILES_util-linux-findfs = "${sbindir}/findfs"
>   FILES_util-linux-getopt = "${base_bindir}/getopt.${BPN}"
> +FILES_util-linux-runuser = "${sbindir}/runuser"
>
>   FILES_util-linux-pylibmount = "${libdir}/${PYTHON_DIR}/dist-packages/libmount/pylibmount.so \
>                                  ${libdir}/${PYTHON_DIR}/dist-packages/libmount/__init__.*"
> @@ -106,7 +108,9 @@ RREPLACES_util-linux-blkid = "e2fsprogs-blkid"
>   # reset calls 'tput'
>   RDEPENDS_util-linux-reset += "ncurses"
>
> -RDEPENDS_${PN} = "util-linux-umount util-linux-swaponoff util-linux-losetup util-linux-sulogin"
> +RDEPENDS_util-linux-runuser += "libpam"
> +
> +RDEPENDS_${PN} = "util-linux-umount util-linux-swaponoff util-linux-losetup util-linux-sulogin util-linux-runuser"

I think that will need to be conditional. Without pam, you won't be able to 
install util-linux because of the missing util-linux-runuser dependency.

>   RRECOMMENDS_${PN} = "util-linux-fdisk util-linux-cfdisk util-linux-sfdisk util-linux-mount util-linux-readprofile util-linux-mkfs "
>
>   RRECOMMENDS_${PN}_class-native = ""
>



Kind regards,

Mike Looijmans
System Expert

TOPIC Embedded Products
Eindhovenseweg 32-C, NL-5683 KH Best
Postbus 440, NL-5680 AK Best
Telefoon: +31 (0) 499 33 69 79
Telefax: +31 (0) 499 33 69 70
E-mail: mike.looijmans@topicproducts.com
Website: www.topicproducts.com

Please consider the environment before printing this e-mail

Visit us at : Aerospace Electrical Systems Expo Europe which will be held from 17.11.2015 till 19.11.2015, Findorffstrasse 101 Bremen, Germany, Hall 5, stand number C65
http://www.aesexpo.eu