Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Jian Liu <jian.liu@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] archiver.bbclass: fix an exception of the mode configured
Date: Mon, 16 Nov 2015 13:17:49 +0800	[thread overview]
Message-ID: <564966FD.8020202@windriver.com> (raw)
In-Reply-To: <1447409389-406-1-git-send-email-jian.liu@windriver.com>

Hi all,

Sorry for a mistake. Please ignore this patch

Jian

On 2015年11月13日 18:09, Jian Liu wrote:
> gcc-source does not have the task do_configure, so if configured mode is set,
> the task do_ar_configured depends on do_configure.
> This will cause an error.
>
> Signed-off-by: Jian Liu <jian.liu@windriver.com>
> ---
>   archiver.bbclass |   15 ++++++++++++---
>   1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/meta/classes/archiver.bbclass b/meta/classes/archiver.bbclass
> index 41a552c..3d1952a 100644
> --- a/meta/classes/archiver.bbclass
> +++ b/meta/classes/archiver.bbclass
> @@ -73,8 +73,18 @@ python () {
>           # We can't use "addtask do_ar_configured after do_configure" since it
>           # will cause the deptask of do_populate_sysroot to run not matter what
>           # archives we need, so we add the depends here.
> -        d.appendVarFlag('do_ar_configured', 'depends', ' %s:do_configure' % pn)
> -        d.appendVarFlag('do_deploy_archives', 'depends', ' %s:do_ar_configured' % pn)
> +        ##
> +        # For some specific packages like gcc-source, do_configure may be deleted.
> +        deltask = d.getVar('__BBDELTASKS', False)
> +        noexec = d.getVarFlag('do_configure', 'noexec')
> +        os.system("echo deltask=%s, noexec=%s, pn=%s >> /tmp/tasks.txt" %(deltask,noexec,pn))
> +        #if 'do_configure' in (d.getVar('__BBDELTASKS', False) or []) or d.getVarFlag('do_configure', 'noexec') == '1':
> +        if d.getVarFlag('do_configure', 'noexec') == '1' or 'do_configure' not in d.getVar('__BBTASKS', False):
> +            pass
> +        else:
> +            bb.build.addtask('do_ar_configured', None, 'do_unpack_and_patch', d)
> +            d.appendVarFlag('do_ar_configured', 'depends', ' %s:do_configure' % pn)
> +            d.appendVarFlag('do_deploy_archives', 'depends', ' %s:do_ar_configured' % pn)
>       elif ar_src:
>           bb.fatal("Invalid ARCHIVER_MODE[src]: %s" % ar_src)
>   
> @@ -348,7 +358,6 @@ do_deploy_archives[sstate-outputdirs] = "${DEPLOY_DIR_SRC}"
>   
>   addtask do_ar_original after do_unpack
>   addtask do_ar_patched after do_unpack_and_patch
> -addtask do_ar_configured after do_unpack_and_patch
>   addtask do_dumpdata
>   addtask do_ar_recipe
>   addtask do_deploy_archives before do_build



  reply	other threads:[~2015-11-16  5:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-13 10:09 [PATCH] archiver.bbclass: fix an exception of the mode configured Jian Liu
2015-11-16  5:17 ` Jian Liu [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-11-16  5:33 Jian Liu
2015-11-16 15:08 ` Burton, Ross
2015-11-17  5:31   ` Jian Liu
2015-12-22  5:08     ` Jian Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=564966FD.8020202@windriver.com \
    --to=jian.liu@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox