From: Alexander Kanavin <alexander.kanavin@linux.intel.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 0/8] Deprecate package_regex.inc and split it into recipes
Date: Wed, 18 Nov 2015 17:48:49 +0200 [thread overview]
Message-ID: <564C9DE1.5090900@linux.intel.com> (raw)
In-Reply-To: <1447861138.12500.83.camel@linuxfoundation.org>
On 11/18/2015 05:38 PM, Richard Purdie wrote:
>> This patch series deprecates package_regex.inc and splits its contents into
>> respective recipes. This is done for same reasons as deprecating
>> upstream_tracking.inc: having upstream version check tweaks bundled into a
>> separate file makes the information prone to getting out of date.
>
> Looking at the patches the one thing that bothers me is the name of this
> variable, "REGEX". In the recipe context its rather ambiguous what it
> means.
>
> I'm wondering if we should take the opportunity to call it something
> like SRC_URI_REGEX or something?
>
> We either do it now or not at all...
I agree. I'll do the rename (from REGEX_URI to UPSTREAM_CHECK_URI and
from REGEX to UPSTREAM_CHECK_REGEX) and resubmit.
This may break upstream versions checks for a while though, because
there may be code accessing these variables that is not in oe-core tree.
Alex
next prev parent reply other threads:[~2015-11-18 15:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 9:52 [PATCH 0/8] Deprecate package_regex.inc and split it into recipes Alexander Kanavin
2015-11-18 9:52 ` [PATCH 1/8] package_regex.inc: deprecate the file Alexander Kanavin
2015-11-18 9:52 ` [PATCH 2/8] package_regex.inc: split entries with odd-even versioning into their own recipes Alexander Kanavin
2015-11-18 9:52 ` [PATCH 3/8] package_regex.inc: split GITTAGREGEX entries into recipe files Alexander Kanavin
2015-11-18 9:52 ` [PATCH 4/8] package_regex.inc: split Debian-related entries into their own recipes Alexander Kanavin
2015-11-18 9:52 ` [PATCH 5/8] package_regex.inc: split PyPi related entries to " Alexander Kanavin
2015-11-18 9:52 ` [PATCH 6/8] package_regex.inc: split sourceforge " Alexander Kanavin
2015-11-18 9:52 ` [PATCH 7/8] package_regex.inc: split entries which blacklist specific versions to their recipes Alexander Kanavin
2015-11-18 9:52 ` [PATCH 8/8] package_regex.inc: split the rest of the entries " Alexander Kanavin
2015-11-18 15:38 ` [PATCH 0/8] Deprecate package_regex.inc and split it into recipes Richard Purdie
2015-11-18 15:48 ` Alexander Kanavin [this message]
2015-11-18 16:06 ` Burton, Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564C9DE1.5090900@linux.intel.com \
--to=alexander.kanavin@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox