From: Robert Yang <liezhi.yang@windriver.com>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>,
OE Core mailing list <openembedded-core@lists.openembedded.org>
Subject: Re: still seems to be a pile of "_append +=" stuff in oe-core
Date: Mon, 23 Nov 2015 09:24:41 +0800 [thread overview]
Message-ID: <56526AD9.5080305@windriver.com> (raw)
In-Reply-To: <alpine.LFD.2.20.1511220702250.16489@localhost>
The _append and += are different, so we need either:
var_append = " foo"
or
var_append += "foo"
for example:
var += "foo"
var = "A"
Then var will be "A".
But:
var_append += "foo"
var = "A"
Then var will be "A foo"
On 11/22/2015 08:04 PM, Robert P. J. Day wrote:
>
> i mentioned this a while back, and it *seems* that there's even more
> of this now -- the use of "_append" in conjunction with "+=", which is
> clearly(?) redundant.
>
> one simply needs to run:
>
> $ grep -r "_append.*+=" *
>
> to see how much of that there is. sure, it doesn't hurt, but it's
> definitely not good programming practice.
>
> rday
>
next prev parent reply other threads:[~2015-11-23 1:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-22 12:04 still seems to be a pile of "_append +=" stuff in oe-core Robert P. J. Day
2015-11-23 1:24 ` Robert Yang [this message]
2015-11-23 2:05 ` Christopher Larson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56526AD9.5080305@windriver.com \
--to=liezhi.yang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox