Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Fabrice Coulon <fabrice.coulon@axis.com>
To: Christopher Larson <clarson@kergoth.com>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] useradd_base: Make perform_groupmems work with native
Date: Tue, 8 Dec 2015 09:50:42 +0100	[thread overview]
Message-ID: <566699E2.2030300@axis.com> (raw)
In-Reply-To: <CABcZANmnKsvaQBykUSZP2_Qsy4oW7v5WwRzF_4vpUbMxkezKPQ@mail.gmail.com>



On 12/07/2015 04:30 PM, Christopher Larson wrote:
>
> On Mon, Dec 7, 2015 at 3:39 AM, Fabrice Coulon 
> <fabrice.coulon@axis.com <mailto:fabrice.coulon@axis.com>> wrote:
>
>     I have a problem when using useradd_base.bbclass together with native.
>     ${sysconfdir} is BUILDDIR/tmp/sysroots/x86_64-linux/etc for native,
>     and ${sysconfdir} is "/etc" for target.
>
>     rootdir is BUILDDIR/tmp/sysroots/x86_64-linux for native, so,
>     $rootdir${sysconfdir} is not correct for native.
>
>     The solution for me was to replace instances of $rootdir${sysconfdir}
>     with $rootdir/etc under perform_groupmems.
>
>     Signed-off-by: Fabrice Coulon <fabrice.coulon@axis.com
>     <mailto:fabrice.coulon@axis.com>>
>
>
> Hardcoding a path is *not* an appropriate fix.

I agree that hardcoding a path is not OK but maybe you should not see 
this as a fix but more like a question/discussion.

The problem is that "/etc" is hardcoded in 13 other places in 
meta/classes/useradd_base.bbclass.

Do you know how to solve this so that it will work well for native?

> -- 
> Christopher Larson
> clarson at kergoth dot com
> Founder - BitBake, OpenEmbedded, OpenZaurus
> Maintainer - Tslib
> Senior Software Engineer, Mentor Graphics



  reply	other threads:[~2015-12-08  8:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-07 10:39 [PATCH] useradd_base: Make perform_groupmems work with native Fabrice Coulon
2015-12-07 15:30 ` Christopher Larson
2015-12-08  8:50   ` Fabrice Coulon [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-12-14 11:12 Fabrice Coulon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=566699E2.2030300@axis.com \
    --to=fabrice.coulon@axis.com \
    --cc=clarson@kergoth.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox