Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Nathan Lynch <Nathan_Lynch@mentor.com>
To: "Aníbal Limón" <anibal.limon@linux.intel.com>
Cc: paul.eggleton@linux.intel.com, georgex.l.musat@intel.com,
	bjst@enea.com, benjamin.esquivel@intel.com,
	openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/2] ptest-runner: Add version 2.0 re-implementation in python.
Date: Fri, 11 Dec 2015 17:23:56 -0600	[thread overview]
Message-ID: <566B5B0C.2000501@mentor.com> (raw)
In-Reply-To: <75b7c85d17559f2f279039e1606fbf1e1e1dee23.1449523356.git.anibal.limon@linux.intel.com>

On 12/07/2015 03:26 PM, Aníbal Limón wrote:
> The new ptest-runner supports timeout of upstream tests executed,
> it looks for stdout of process and if no information is available
> in certain time (defaults to 5m) the process is treaty as blocked
> and ptest-runner kills it, this handles problems of ptest-runner
> being blocked indefinitly for upstream test suites.

Having the option to specify a timeout is obviously useful, but please
add the ability to wait indefinitely, and consider making this the
default behavior.  The appropriate value for a timeout, if any, will
always be a function of the particular circumstances of the test run.
An indefinite wait at least gives one the opportunity to investigate a
misbehaving test without racing the test harness.

> +DEFAULT_TIMEOUT_SECS = 500

The change description says the default is five minutes, but this is not
five minutes :-)




  reply	other threads:[~2015-12-11 23:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-07 21:26 [PATCH 0/2] ptest-runner Aníbal Limón
2015-12-07 21:26 ` [PATCH 1/2] ptest-runner: Add version 2.0 re-implementation in python Aníbal Limón
2015-12-11 23:23   ` Nathan Lynch [this message]
2015-12-14 15:50     ` Aníbal Limón
2015-12-07 21:26 ` [PATCH 2/2] ptest-runner: Add a recipe for install ptest-runner 2.0 Aníbal Limón
2015-12-10 19:53 ` [PATCH 0/2] ptest-runner Aníbal Limón

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=566B5B0C.2000501@mentor.com \
    --to=nathan_lynch@mentor.com \
    --cc=anibal.limon@linux.intel.com \
    --cc=benjamin.esquivel@intel.com \
    --cc=bjst@enea.com \
    --cc=georgex.l.musat@intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=paul.eggleton@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox