From: Alexander Kanavin <alexander.kanavin@linux.intel.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/6] lttng-modules: fix build issue against kernel 4.4
Date: Mon, 21 Dec 2015 13:39:15 +0200 [thread overview]
Message-ID: <5677E4E3.6010607@linux.intel.com> (raw)
In-Reply-To: <CAP9ODKoENbVi-ALn-2PWdW9pv1BfGbyejBQrf7md3bH3FnJFCQ@mail.gmail.com>
On 12/21/2015 01:27 PM, Otavio Salvador wrote:
> Commit logs are suppose to have the information useful to understand
> the reason of the change. Latest hides all behind it and does not
> communicate anything. I don't think expect people to read the code to
> know you bumped (and to which) revision is right.
Having the exact upstream commit id - a bunch of random numbers and
letters - in the commit message does not make the commit message any
more useful, readable, or searchable. You can't even click on that id to
open a gitweb webpage with the upstream patch (having that kind of link
*would* be useful though).
The change to the recipe is short, and no one should be overwhelmed by
looking at it if they need the commit id.
Alex
next prev parent reply other threads:[~2015-12-21 11:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 20:44 [PATCH 0/6] linux-yocto: consolidate pull request Bruce Ashfield
2015-12-18 20:44 ` [PATCH 1/6] yaffs2: fix checkpoint functionality Bruce Ashfield
2015-12-18 20:44 ` [PATCH 2/6] lttng-modules: fix build issue against kernel 4.4 Bruce Ashfield
2015-12-19 10:05 ` Otavio Salvador
2015-12-19 17:44 ` Bruce Ashfield
2015-12-19 17:48 ` Bruce Ashfield
2015-12-21 11:27 ` Otavio Salvador
2015-12-21 11:39 ` Alexander Kanavin [this message]
2015-12-22 0:08 ` Bruce Ashfield
2015-12-18 20:44 ` [PATCH 3/6] linux-yocto-dev: bump to 4.4-rcX Bruce Ashfield
2015-12-18 20:44 ` [PATCH 4/6] linux-yocto/4.1: update to v4.1.15 Bruce Ashfield
2015-12-18 20:44 ` [PATCH 5/6] kernel-yocto: fix checkout bare-cloned kernel repositories Bruce Ashfield
2015-12-18 20:44 ` [PATCH 6/6] linux-yocto: remove 3.14 and 3.19 recipes Bruce Ashfield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5677E4E3.6010607@linux.intel.com \
--to=alexander.kanavin@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox