Re: [PATCH V1 1/3] kernel.bbclass: do not install initramfs bundled kernel image

[Bruce Ashfield <bruce.ashfield@windriver.com>]

On 15-12-30 04:19 PM, Ming Liu wrote:
> From: Ming Liu <peter.x.liu@external.atlascopco.com>
>
> It makes no sense to install a initramfs bundled kernel image since
> do_package does not depend on do_bundle_initramfs at all, otherwise, it
> leads to a impicit kernel-image package depending on do_package run before
> or after do_bundle_initramfs.

It may just be the holiday break that has me thinking slower than
normal .. but I'm missing an overall description of the problem you are
trying to solve with this series, and also a writeup of how the new
implementation works.

Can you re-submit this with a 0/N that describes the issue with the
current implementation, and how this series solves it .. and then
perhaps the individual patches will make more sense.

We were able to bundle in the past, but the message I'm getting from
the commit messages is that something fundamental isn't working, but
I can't quite put the whole picture together without some more context.

Bruce


>
> Signed-off-by: Ming Liu <peter.x.liu@external.atlascopco.com>
> ---
>   meta/classes/kernel.bbclass | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 4ce1611..d1ca614 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -179,10 +179,6 @@ do_bundle_initramfs () {
>   		kernel_do_compile
>   		mv -f ${KERNEL_OUTPUT} ${KERNEL_OUTPUT}.initramfs
>   		mv -f ${KERNEL_OUTPUT}.bak ${KERNEL_OUTPUT}
> -		# Update install area
> -		echo "There is kernel image bundled with initramfs: ${B}/${KERNEL_OUTPUT}.initramfs"
> -		install -m 0644 ${B}/${KERNEL_OUTPUT}.initramfs ${D}/boot/${KERNEL_IMAGETYPE}-initramfs-${MACHINE}.bin
> -		echo "${B}/${KERNEL_OUTPUT}.initramfs"
>   	fi
>   }
>
>